Skip to content

Few improvements #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
S-S-X opened this issue Dec 29, 2021 · 2 comments · Fixed by #7
Closed

Few improvements #5

S-S-X opened this issue Dec 29, 2021 · 2 comments · Fixed by #7
Assignees
@S-S-X
Labels
enhancement New feature or request

Comments

@S-S-X
Copy link
Member

S-S-X commented Dec 29, 2021

  • Forward last login timestamp through geoip.joinplayer_callback.
    • Required
  • Allow registering event handlers for geoip.joinplayer_callback.
    • Previous callback override style can stay around or it can be replaced, TBD?
    • Not as important and not really required, function override works too and might be better to allow cutting chain if player is removed?

This is to make upcoming beowulf updates a lot simpler.
@S-S-X S-S-X added the enhancement New feature or request label Dec 29, 2021
@S-S-X S-S-X self-assigned this Dec 29, 2021
@S-S-X
Copy link
Member Author

S-S-X commented Dec 30, 2021

Also done and including some mod.conf / luacheck stuff.

@S-S-X
Copy link
Member Author

S-S-X commented Dec 30, 2021

mt-mods/beowulf#6

@S-S-X S-S-X mentioned this issue Jan 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S-S-X S-S-X

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GeoIP updates mt-mods/geoip
1 participant
@S-S-X