Skip to content

Conversation

@wsobel
Copy link
Member

@wsobel wsobel commented Nov 12, 2025

Added bash to apk so m4 installs correctly in build. Not sure why system m4 is not used.

Update alpine version to 3.22

@wsobel wsobel requested a review from Copilot November 12, 2025 12:25
@wsobel wsobel requested a review from simonyg November 12, 2025 12:25
Copilot finished reviewing on behalf of wsobel November 12, 2025 12:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Alpine Docker image to version 3.22 and adds bash as a dependency to fix an issue with the m4 package installation during Conan builds.

  • Updates Alpine base image from 3.19 to 3.22
  • Adds bash package to support m4 installation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wsobel wsobel changed the title Conan build on alpine for m4 now requires bash. apk added bash For docker alpine build, added bash because of m4 and changed verion from 3.18 to 3.22 Nov 12, 2025
@wsobel wsobel changed the title For docker alpine build, added bash because of m4 and changed verion from 3.18 to 3.22 For docker alpine build, added bash because of m4 and changed verion to 3.22 Nov 12, 2025
@wsobel wsobel requested a review from Copilot November 14, 2025 16:13
Copilot finished reviewing on behalf of wsobel November 14, 2025 16:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wsobel wsobel requested a review from Copilot November 16, 2025 18:35
Copilot finished reviewing on behalf of wsobel November 16, 2025 18:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 20 out of 22 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wsobel wsobel merged commit cdc5986 into main Nov 16, 2025
7 checks passed
@wsobel wsobel deleted the fix_docker_build_issues_with_alpine branch November 18, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants