[InputBase] Fix onFilled/onEmpty being called during render (#15319)

Author: eps1lon

packages/material-ui/src/InputBase/InputBase.js

@@ -156,19 +156,14 @@ class InputBase extends React.Component {
   constructor(props) {
     super(props);
     this.isControlled = props.value != null;
-    if (this.isControlled) {
-      this.checkDirty(props);
-    }
   }
 
   state = {
     focused: false,
   };
 
   componentDidMount() {
-    if (!this.isControlled) {
-      this.checkDirty(this.inputRef);
-    }
+    this.checkDirty(this.isControlled ? this.props : this.inputRef);
   }
 
   componentDidUpdate(prevProps) {

packages/material-ui/src/InputBase/InputBase.test.js

@@ -396,51 +396,6 @@ describe('<InputBase />', () => {
     });
   });
 
-  describe('componentDidMount', () => {
-    let wrapper;
-    let instance;
-
-    before(() => {
-      wrapper = mount(<NakedInputBase classes={classes} />);
-      instance = wrapper.find('InputBase').instance();
-    });
-
-    beforeEach(() => {
-      instance.checkDirty = spy();
-    });
-
-    it('should not call checkDirty if controlled', () => {
-      instance.isControlled = true;
-      instance.componentDidMount();
-      assert.strictEqual(instance.checkDirty.callCount, 0);
-    });
-
-    it('should call checkDirty if controlled', () => {
-      instance.isControlled = false;
-      instance.componentDidMount();
-      assert.strictEqual(instance.checkDirty.callCount, 1);
-    });
-
-    it('should call checkDirty with input value', () => {
-      instance.isControlled = false;
-      instance.inputRef = 'woofinput';
-      instance.componentDidMount();
-      assert.strictEqual(instance.checkDirty.calledWith(instance.inputRef), true);
-    });
-
-    it('should call or not call checkDirty consistently', () => {
-      instance.isControlled = true;
-      instance.componentDidMount();
-      assert.strictEqual(instance.checkDirty.callCount, 0);
-      instance.isControlled = false;
-      instance.componentDidMount();
-      assert.strictEqual(instance.checkDirty.callCount, 1);
-      instance.isControlled = true;
-      instance.componentDidMount();
-      assert.strictEqual(instance.checkDirty.callCount, 1);
-    });
-  });
-
   describe('mount', () => {
     it('should be able to access the native input', () => {
       const handleRef = spy();