Skip to content

PR #22716 with fix of bug #21166 has not been merged in v4 #32645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ivan-freedomfi opened this issue May 5, 2022 · 1 comment
Closed

PR #22716 with fix of bug #21166 has not been merged in v4 #32645

ivan-freedomfi opened this issue May 5, 2022 · 1 comment
Assignees
@siriwatknp
Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) typescript v4.x

Comments

@ivan-freedomfi
Copy link

ivan-freedomfi commented May 5, 2022 •
edited
Loading

Duplicates

Current behavior 😯

The commit with the fix of the issues mentioned was released only in v5.x releases: 4f21dfc

material-ui-versions

No `v4` releases above for this PR.

You can see it's present inv5.0.0-alpha.11 changelog:

[core] Replace ChangeEvent<{}> with SyntheticEvent (#22716) @eps1lon

But the fix is not in v4 releases

It fixes issues #21166 and #17454

Are you going to merge this PR back in v4?

Steps to Reproduce

See CodeSandBox with the issue reproduced (Material v4.12.4): https://codesandbox.io/s/material-demo-forked-hlqon3?file=/demo.tsx

image
@ivan-freedomfi ivan-freedomfi added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 5, 2022
@ivan-freedomfi ivan-freedomfi changed the title Fix (PR) [22716](https://github.com/mui/material-ui/pull/22716) not merged in v4 Fix PR !22716 not merged in v4 May 5, 2022
@ivan-freedomfi ivan-freedomfi changed the title Fix PR !22716 not merged in v4 Fix PR #22716 not merged in v4 May 5, 2022
@ivan-freedomfi ivan-freedomfi changed the title Fix PR #22716 not merged in v4 PR #22716 with fixes of bug #21166 were not merged in v4 May 5, 2022
@ivan-freedomfi ivan-freedomfi changed the title PR #22716 with fixes of bug #21166 were not merged in v4 PR #22716 with fixes of bug #21166 has not been merged in v4 May 5, 2022
@ivan-freedomfi ivan-freedomfi changed the title PR #22716 with fixes of bug #21166 has not been merged in v4 PR #22716 with fix of bug #21166 has not been merged in v4 May 5, 2022
@eps1lon
Copy link
Member

eps1lon commented May 5, 2022

We only backport critical fixes to v4. A type-related change is not critical.

@eps1lon eps1lon closed this as completed May 5, 2022
@siriwatknp siriwatknp added out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) typescript and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
out of scope The problem looks valid but we won't fix it (maybe we will revisit it in the future) typescript v4.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@oliviertassinari @eps1lon @siriwatknp @ivan-freedomfi