Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude special-use domains from proxy #250

Open
cohesive-flight opened this issue Oct 30, 2024 · 5 comments
Open

Exclude special-use domains from proxy #250

cohesive-flight opened this issue Oct 30, 2024 · 5 comments
Labels
proxy This is related to the socks proxy feature

Comments

@cohesive-flight
Copy link

cohesive-flight commented Oct 30, 2024

The extension currently proxies special-use domains, such as home.arpa, causing them to be inaccessible unless set to never be proxied. There's also the .internal TLD, which is reserved for private-use.

@ruihildt
Copy link
Member

ruihildt commented Nov 7, 2024

Can you check if this is still the case with the latest release?

@ruihildt ruihildt added the proxy This is related to the socks proxy feature label Nov 7, 2024
@cohesive-flight
Copy link
Author

It is still an issue with the latest release.

@ruihildt
Copy link
Member

ruihildt commented Nov 8, 2024

Sorry I didn't look more in depth first, it turns out the only domain I exclude manually is "localhost". The main logic of excluding local traffic is IP based.

Ideally I would prefer to use a third-party library, since this is definitely not my area of expertise, but in any case, I can hard-code the whole list as well.

Reference: https://datatracker.ietf.org/doc/html/rfc6761

@ruihildt ruihildt moved this from Triage to Next in Mullvad Browser Extension Dec 12, 2024
@ruihildt
Copy link
Member

I had a look at the RFC, here's how each domain is categorized:

Application software SHOULD NOT recognize these names as special, and SHOULD use these names as they would other reverse-mapping names.

  • arpa.
  • test.
  • example.
  • example.com.
  • example.net.
  • example.org.

Application software MAY recognize localhost names as special, or MAY pass them to name resolution APIs as they would for other domain names.

  • localhost.

While invalid. is actually not part of the spec yet. Here's the working draft: https://datatracker.ietf.org/doc/html/draft-davies-internal-tld-02

Following the RFC, it seems the current implementation is correct. It's up to the user to add any exception they'd like. (Which is incidentally the same approach Firefox has in the Network Settings)

@ruihildt
Copy link
Member

@cohesive-flight Is there a specific reason, adding any of these domains manually as exceptions doesn't work for you?

@ruihildt ruihildt moved this from Next to Triage in Mullvad Browser Extension Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy This is related to the socks proxy feature
Projects
Development

No branches or pull requests

2 participants