-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude special-use domains from proxy #250
Comments
Can you check if this is still the case with the latest release? |
It is still an issue with the latest release. |
Sorry I didn't look more in depth first, it turns out the only domain I exclude manually is "localhost". The main logic of excluding local traffic is IP based. Ideally I would prefer to use a third-party library, since this is definitely not my area of expertise, but in any case, I can hard-code the whole list as well. |
I had a look at the RFC, here's how each domain is categorized:
While Following the RFC, it seems the current implementation is correct. It's up to the user to add any exception they'd like. (Which is incidentally the same approach Firefox has in the Network Settings) |
@cohesive-flight Is there a specific reason, adding any of these domains manually as exceptions doesn't work for you? |
The extension currently proxies special-use domains, such as home.arpa, causing them to be inaccessible unless set to never be proxied. There's also the .internal TLD, which is reserved for private-use.
The text was updated successfully, but these errors were encountered: