Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per Tab Proxy Does Not Work #273

Closed
issuant opened this issue Jan 8, 2025 · 3 comments
Closed

Per Tab Proxy Does Not Work #273

issuant opened this issue Jan 8, 2025 · 3 comments
Labels
proxy This is related to the socks proxy feature

Comments

@issuant
Copy link

issuant commented Jan 8, 2025

Manually setting up a domain proxy (#226 (comment)) before navigating to the site does not do anything. It adds the domain to the list of actively proxied sites but when you navigate to the actual site, the extension indicates the site is still routed through the 'All websites' proxy. Even after refreshing, the extension icon continues to show the country code of the 'All websites' proxy for the page.

@ruihildt
Copy link
Member

@issuant Can you confirm you have the same issue with the latest 0.9.4 update?

I couldn't reproduce the issue.

@ruihildt ruihildt added the proxy This is related to the socks proxy feature label Jan 27, 2025
@ruihildt ruihildt moved this from Triage to Next in Mullvad Browser Extension Jan 27, 2025
@ruihildt ruihildt moved this from Next to In Progress in Mullvad Browser Extension Jan 27, 2025
@issuant
Copy link
Author

issuant commented Jan 28, 2025

The update has fixed it.

There is a slight issue though. When the extension pops up in a tab that is proxied differently, the upper part, above the 'All websites' divider, is filled with the information of the 'All websites' proxy instead of the tab's specific proxy, which is shown below but is very de-emphasized and easy to miss.

A separate issue related to #274 is that when setting up domains like old.reddit.com, the settings seem to not apply to plain reddit.com too. I remember a comment from you saying it would apply by default but maybe I am misremembering, or it is in reverse, so it is reddit.com that would apply to old.reddit.com. I think there should be a warning or notification for this, like the (except for domains listed below) beside 'All websites'.

@ruihildt
Copy link
Member

I'll close this as fixed.

@issuant For the two last points raised:

  • indeed, the connection check is always made for All websites, maybe we should do it based on the current domain proxy if it exists. There's some UI research to be made, so I opened this issue: ConnCheck should show information about the current tab. #282
  • the behavior is to by default always apply the proxy from a top level domain to subdomain: if only a subdomain is configured, then the top level domain will not proxy. I may look at doing things differently if users are confused

@github-project-automation github-project-automation bot moved this from In Progress to Done in Mullvad Browser Extension Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proxy This is related to the socks proxy feature
Projects
Archived in project
Development

No branches or pull requests

2 participants