Skip to content

Latest commit

 

History

History
179 lines (124 loc) · 6.66 KB

CONTRIBUTING.md

File metadata and controls

179 lines (124 loc) · 6.66 KB

Contributing

Public domain

This project is in the public domain within the United States, and copyright and related rights in the work worldwide are waived through the CC0 1.0 Universal public domain dedication.

All contributions to this project will be released under the CC0 dedication. By submitting a pull request, you are agreeing to comply with this waiver of copyright interest.

Development Process

This project follows the git flow branching model of product development.

Testing

To run all the tests: npm test

For testing in Midas, we are using:

  • mocha test framework
  • chai assertion library
  • request to make http calls for testing API endpoints

The following command will execute a single test file in the application context: NODE_ENV=test ./node_modules/.bin/mocha test/test.upstart.js test/api/sails/tag.test.js

Backbone

Git Hooks

When working in the development environment, be sure to install the project specific git hooks.

 tools/git_hooks/create-sym-links

Code Style

Generally try to follow the Google Javascript Style Guide. Spaces should be used instead of tabs, and the tab width should be set to 2 spaces. No spaces at the end of lines.

Commit Messages

Treat commit messages as an email message that describes what you changed and why.

The first line of the commit log must be treated as as an email subject line. It must be strictly no greater than 50 characters long. The subject must stand on its own and not only make external references such as to relevant bug numbers.

The second line must be blank.

The third line begins the body of the commit message (one or more paragraphs) describing the details of the commit. Paragraphs are each separated by a blank line. Paragraphs must be word wrapped to be no longer than 76 characters.

The last part of the commit log should contain all "external references", such as which issues were fixed.

Database changes

The database schema is managed in this repository under /tools/postgres/. When you first set up Midas and run npm run init the init.sh script sets up the database with the latest schema. Each subsequent run of init.sh checks the database version and runs migration scripts to update it if the database is out of data.

When making a database change, write a shell script that updates the database to your desired schema. Save this shell script as [version].sh where [version] is the new version of the schema. Migration scripts should be saved in /tools/postgres/migrate. See scripts in that directory like 2.sh for examples.

Then, export the updated schema:

pg_dump -h localhost -p 5432 -U midas -s midas > ./tools/postgres/schema/current.sql

The schema is also updated each time you run make build.

Submission Guidelines

Submitting an Issue

Before you submit your issue search the archive, maybe your question was already answered.

If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. Providing the following information will increase the chances of your issue being dealt with quickly:

  • Overview of the issue - if an error is being thrown a non-minified stack trace helps
  • Motivation for or Use Case - explain why this is a bug for you
  • Midas Version(s) - is it a regression?
  • Browsers and Operating System - is this a problem with all browsers or only IE8?
  • Reproduce the error - provide a live example, screenshot, and/or a unambiguous set of steps. The more the better.
  • Related issues - has a similar issue been reported before? Reference the related issues in the descrioption.
  • Suggest a Fix - if you can't fix the bug yourself, perhaps you can point to what might be causing the problem (line of code or commit). If you're requesting a feature, describe how the feature might work to resolve the user story.

Submitting a Pull Request

Before you submit your pull request consider the following guidelines:

  • Search GitHub for an open or closed Pull Request that relates to your submission. You don't want to duplicate effort.

  • Make your changes in a new git branch

    git checkout -b my-fix-branch devel

  • Create your patch, including appropriate test cases.

  • Follow our Code Style.

  • Run the full Midas test suite, including make test and make demo, and ensure that all tests pass.

  • Commit your changes using a descriptive commit message that follows our commit message conventions and passes our commit message presubmit hook pre-commit and commit-msg (see git hooks). Adherence to the commit message conventions is required to assist in generating release notes.

    git commit -a

    Note: the optional commit -a command line option will automatically "add" and "rm" edited files.

  • Build your changes locally to ensure all the tests pass

    npm test

  • Push your branch to GitHub:

    git push origin my-fix-branch

  • In GitHub, send a pull request to midas:devel.

  • If we suggest changes then:

    • Make the required updates.

    • Re-run the Midas test suite to ensure tests are still passing.

    • Rebase your branch and force push to your GitHub repository (this will update your Pull Request):

      git rebase devel -i
git push -f

That's it! Thank you for your contribution!

After your pull request is merged

After your pull request is merged, you can safely delete your branch and pull the changes from the main (upstream) repository:

  • Delete the remote branch on GitHub either through the GitHub web UI or your local shell as follows:

    git push origin --delete my-fix-branch

  • Check out the devel branch:

    git checkout devel -f

  • Delete the local branch:

    git branch -D my-fix-branch

  • Update your devel with the latest upstream version:

    git pull --ff upstream devel