bug: Artworks are not displayed in the Playbar/Queue

[onl1ner]

Artworks are not displayed for some songs. This is likely a framework issue

[onl1ner]

This is also a problem for entries in the queue. Every item has nil in the artwork property

[CursiveHello]

Hey Tamerlan, Linus here. Thanks for keeping a small, simple codebase!

I’ve found a worse bug and I think it has the same root cause.

Whenever I play an Apple Music song, the audio starts, but the app freezes and CPU and memory usage start climbing. The console repeatedly shows -[ITLibraryArtworkDataSource visualIdenticalityIdentifierForCatalog:]: Missing Catalyst implementation!. It doesn’t happen when I play a purchased song.

I’ve pinpointed the culprit: in MusicArtworkImage, if I comment out the call to MusicKit’s ArtworkImage, the bug goes away. So I think it’s a bug in MusicKit. Demo code here.

That leaves the question of why ArtworkImage works sometimes but not always. Does it behave differently when audio is playing, or with certain Artwork arguments?

Freeze.mov

[onl1ner]

Hi Linus,

In the Library page, there are cases where artwork does not return an image URL. However, the ArtworkImage implementation in MusicKit somehow manages to retrieve and use it. This is why the MusicArtworkImage component includes a fallback to ArtworkImage.

Currently, the Library page is quite unstable due to inconsistencies in the return values for entries such as albums and playlists. These differences include varying IDs for the entries themselves and for the songs within them. As a result, this part of the app requires refinement.

I wish I had more free time to address this and implement a solution. In the meantime, if you feel up to the challenge, please feel free to propose and introduce your solution.

Thanks for digging into the issue!

[CursiveHello]

varying IDs for the entries themselves and for the songs within them

Oof, I think I know what you mean. In my experience, the MusicItemIDs in a MusicPlayer’s queue don’t match the ones you just told it to play. It’s one reason I still use Media Player sometimes.

Thanks for the info!