Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for required environment variables #67

Open
mwarkentin opened this issue Dec 1, 2015 · 3 comments
Open

Check for required environment variables #67

mwarkentin opened this issue Dec 1, 2015 · 3 comments

Comments

@mwarkentin
Copy link
Owner

mwarkentin commented Dec 1, 2015

Configure a list of environment variables to assert are set in settings.py.

Should there be some default environment variables to check?

  • SECRET_KEY
  • WATCHMAN_TOKENS
  • ??
@stale
Copy link

stale bot commented Jan 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 30, 2018
@mwarkentin mwarkentin added pinned and removed stale labels Feb 5, 2018
@sshishov
Copy link

Personally I do not understand this check. If the evn variable is required, you server will not just start and already will produce 502 or ConnectionRefused.
If the variable is there, then everything is started and no need to check anything. Am I missing something here?

@mwarkentin
Copy link
Owner Author

@sshishov it's been quite a while since I opened this ticket, but I think what I was thinking was around the possibility of using Django-watchman as a check on a new deployment before cutting traffic over..

  1. Deploy new code but don't send traffic yet
  2. Manually or automatically use the watchman CLI on the new release to confirm everything is looking good (including expected env vars are set)
  3. If good, begin rolling out new release - otherwise fail and alert about the bad deploy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants