Replace function call with language construct (isset([]) evaluates to true)

Willem Stuursma · Willem Stuursma · commit ec1d4fc21364 · 2018-07-31T17:31:44.000+02:00
diff --git a/src/Enum.php b/src/Enum.php
@@ -119,7 +119,7 @@ public static function values()
     public static function toArray()
     {
         $class = \get_called_class();
-        if (!\array_key_exists($class, static::$cache)) {
+        if (!isset(static::$cache[$class])) {
             $reflection            = new \ReflectionClass($class);
             static::$cache[$class] = $reflection->getConstants();
         }

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ public static function values()`
`119`	`119`	`public static function toArray()`
`120`	`120`	`{`
`121`	`121`	`$class = \get_called_class();`
`122`		`- if (!\array_key_exists($class, static::$cache)) {`
	`122`	`+ if (!isset(static::$cache[$class])) {`
`123`	`123`	`$reflection = new \ReflectionClass($class);`
`124`	`124`	`static::$cache[$class] = $reflection->getConstants();`
`125`	`125`	`}`