-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement history management #6
Comments
Hello, i wrote a header file, that writes the entered command to the file "$HOME/.psh/history" and it creates the directory if it does not exist. Its pretty simple to use, currently the function call is placed in the main2.c file after the I included the header file in this comment, im sorry for the format, but Github doesnt accept I have tested the file on an arco Linux machine, and it worked as expected without any warning or error. After using it the first time you will get a new folder in your home directory containing a history file that holds all entered commands. Currently i struggle a little bit with doxygen to create a proper documentation for the file. Please excuse my mistakes, im fairly new to c and to Github. Looking forward to your reply. :) Sincerely, |
Dear Manuel,
Thanks! You just can’t imagine how excited I was when I saw your message. Your contribution is much appreciated. I will definitely take your code into account when doing this part. I really like your idea of putting everything into a folder, instead of creating a whole crowd of files like what `bash` and `zsh` are doing.
However, there are still some issues about history to be resolved. I have to rewrite `builtins/history.c` (#16) before handling saving/loading history. But before that, I think I should finish implementing variables (#8) first. So there’s still lots to do. I’m sorry, but only when those bunch of things is done can I work on this😢.
But don’t be sad or discouraged. I am also a beginner. And I remembered my first issue and pull request when I saw your message. GitHub is a big family, and there are a lot of projects to contribute to in the meantime.
Good luck coding!
Regards,
Maiyun
|
No description provided.
The text was updated successfully, but these errors were encountered: