Skip to content

Conversation

@matheus23
Copy link
Member

Description

This reverts a change from this PR: #3384

I originally thought I could make this test more reliable by pausing the tokio time across the tokio::time::timeout calls, but it turns out that actually makes the test more flaky:

  • When time is paused, the timeout will immediately fire once the tokio runtime has no more CPU work to do.
  • It's possible that there's no CPU work to do anymore, while there's something else that is actually still doing work, e.g. networking.
  • Before the ActiveRelayActor finishes its run_connected loop, it will call client_sink.close().await, which will do actual I/O. When the tokio runtime is paused at that moment, it'll immediately trigger the test's timeout.

Notes & open questions

I couldn't reproduce this problem even across a couple thousand runs of the test locally. I'm not super confident that this fixes things, but I've analyzed the logs and this seems to be the most likely thing that's happening to me.

Closes #3613

Change checklist

  • Self-review.

@matheus23 matheus23 self-assigned this Nov 18, 2025
@n0bot n0bot bot added this to iroh Nov 18, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Nov 18, 2025
@github-actions
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3680/docs/iroh/

Last updated: 2025-11-18T17:08:59Z

@github-actions
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: c83249c

@matheus23 matheus23 merged commit 160d535 into feat-multipath Nov 20, 2025
26 of 28 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Nov 20, 2025
@matheus23 matheus23 deleted the matheus23/fix-active-relay-inactive-flake branch November 20, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants