test(iroh): Fix test_active_relay_inactive test being flaky
#3680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts a change from this PR: #3384
I originally thought I could make this test more reliable by pausing the tokio time across the
tokio::time::timeoutcalls, but it turns out that actually makes the test more flaky:ActiveRelayActorfinishes itsrun_connectedloop, it will callclient_sink.close().await, which will do actual I/O. When the tokio runtime is paused at that moment, it'll immediately trigger the test's timeout.Notes & open questions
I couldn't reproduce this problem even across a couple thousand runs of the test locally. I'm not super confident that this fixes things, but I've analyzed the logs and this seems to be the most likely thing that's happening to me.
Closes #3613
Change checklist