Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q. Why are some statements duplicated in the triangulation code when pushing centers? #11

Open
willingc opened this issue Jan 31, 2025 · 2 comments

Comments

@willingc
Copy link
Contributor

Related to zulip comment

Several places in the triangulate paths code related to centers have duplicate code.

triangles.centers.push(p2);

I'm trying to understand why, and if we should comment somewhere.

@Czaki
Copy link
Contributor

Czaki commented Jan 31, 2025

Ah. This is caused by existing implementation where we pass triangles as centers + offest
So for each point on the path we repeat it twice or three times.

You may see examples in napari/napari#7268

We do this, to speed up edge width scaling.

@willingc
Copy link
Contributor Author

Thanks! Let's leave this open as a placeholder for future deduplication or commenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants