Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion with collapse and minSize #188

Open
DemersM opened this issue Mar 5, 2019 · 3 comments
Open

Suggestion with collapse and minSize #188

DemersM opened this issue Mar 5, 2019 · 3 comments

Comments

@DemersM
Copy link

DemersM commented Mar 5, 2019

In my point of view, collapse should resize to 0 even if the minSize is superior. The minSize should affect the size when dragging/resizing only.

Then we could use the collapse function to hide the pane while assuring that it wont be smaller than the minSize when visible.

This will be closer to the definition of the word collapse.

@looeee
Copy link

looeee commented Sep 17, 2019

This will be closer to the definition of the word collapse.

Not really. If you collapse a real world object, it doesn't shrink to an infinitesimal point, it just goes into its "smallest state". To me, collapsing to minSize seems intuitive and correct. If I want the pane to collapse to zero then I'll set 0 as the min size.

I suspect this is one of those situations where either version of the function will be correct for some use cases and incorrect for others.

@DaleyKD
Copy link

DaleyKD commented Nov 12, 2021

I agree with the OP. I'm sure there are 20 who will disagree with me. :)

I need to find a way to use Split.js for it's resizing of panes but also to use it like an accordion (or Bootstrap collapsible, whatever).

@cloudsolace
Copy link

+1 on this enhancement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants