Skip to content

Lowe’s first-to-second neighbor ratio test #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sysuzyq opened this issue May 9, 2022 · 0 comments
Open

Lowe’s first-to-second neighbor ratio test #3

sysuzyq opened this issue May 9, 2022 · 0 comments

Comments

@sysuzyq
Copy link

sysuzyq commented May 9, 2022

nice work.
https://github.com/naver/fire/blob/main/losses.py#L46

    dist2_second2 = torch.argmin(dist2, dim=0)
    ratio1to2 = dist[best2,arange] / dist2_second2. # should it be  dist[best2,arange] /dist2[dist2_second2:arange] ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sysuzyq