Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Run all scripts in a directory #8

Open
dwagon opened this issue Mar 25, 2019 · 1 comment
Open

Feature Request: Run all scripts in a directory #8

dwagon opened this issue Mar 25, 2019 · 1 comment

Comments

@dwagon
Copy link

dwagon commented Mar 25, 2019

It would be great if you could run all the scripts in a specified directory without needing to change the config to specify each one in turn. This would make the addition of new scripts a trivial exercise and prevent the centralised prometheus config from getting out of hand in large sites.

Thanks

@ncabatoff
Copy link
Owner

It makes sense, but I coded it the way I did out of an abundance of caution. By requiring each script to be hand-coded, you're less likely to have someone sneak a file into a directory and trick you into executing it with potentially elevated privileges.

Someone else wrote a very similar exporter before me, but I only discovered it subsequently because they chose a very odd name. Unfortunately I forget the name, but if I rediscover it I'll post it here, because I think they were more liberal in a way that would address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants