Skip to content

Option to turn off feature filtering for heatmap #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bnovotny opened this issue Jan 13, 2022 · 1 comment
Open

Option to turn off feature filtering for heatmap #160

bnovotny opened this issue Jan 13, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@bnovotny
Copy link

Is your feature request related to a problem? Please describe.
For my data, the heatmap doesn't load when features are filtered by VMR, and the VMR must be manually set to 0 each time the browser is loaded for the heatmap to render.

Describe the solution you'd like
An option to disable filtering, either in the UI by checkbox (something like "filter features?" in the Ingest tab or sidebar) and/or as an option for developers to disable that feature entirely. If this is implemented as a checkbox in the UI, it would be great to be able to set the default selection (checked/unchecked) as well.

Describe alternatives you've considered
A call to validate() with a message like "change the feature filtering settings in the sidebar to render the heatmap" in the heatmap server function to avoid the error message below.

Additional context
image

@ricoderks
Copy link
Collaborator

This is probably not a quick change.
To avoid the error you can uncheck calculate VMR? and click on Load Data. The data will still be filtered, but on what is selected in the pull down box below (which often will be just the feature name). This is just temporary. I agree that we should have an option to disable filtering completely with maybe a warning that if you have a lot of features it shows an advise to limit the amount of features.

@ergonyc ergonyc added the enhancement New feature or request label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants