Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize terminology #275

Open
arunasank opened this issue Oct 14, 2024 · 1 comment
Open

Standardize terminology #275

arunasank opened this issue Oct 14, 2024 · 1 comment

Comments

@arunasank
Copy link

Currently, in the attribution and activation patching examples on nnsight, patching is done FROM clean TO corrupt. While, in standardized settings patching is done FROM corrupt TO clean. A better set of terms could also be base and source.

Will submit a PR for this soon if it seems ok, and someone doesn't beat me to it. :)

cc/ @JadenFiotto-Kaufman Can you please 👍 if this sounds reasonable?
@JadenFiotto-Kaufman
Copy link
Member

@arunasank Absolutely go ahead and I will merge it in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arunasank @JadenFiotto-Kaufman