Skip to content

Support include directives #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
parsonsmatt opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1633
Open

Support include directives #1632

parsonsmatt opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1633
Labels
good first issue

Comments

@parsonsmatt
Copy link

The yaml package has a Data.Yaml.Include API which allows you to use include directives to reference other files.

We want to use this to allow us to have an hlint-rules directory, and different teams can own their own hlint rules via CODEOWNERS. This way, they can be in charge of their own rules, and any modification or exclusion of those rules would trigger review for the relevant team.
@zliu41
Copy link
Collaborator

zliu41 commented Jan 29, 2025

That sounds quite useful, thanks for the idea!

@parsonsmatt parsonsmatt linked a pull request Jan 29, 2025 that will close this issue
Draft
@parsonsmatt
Copy link
Author

So, it is also possible to pass multiple hlint files with --hint. I may go this route instead as #1639 means I can't import these in groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Data.Yaml.Include parsonsmatt/hlint
2 participants
@zliu41 @parsonsmatt