Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Relax Ingress Check When Using DNS Challenge #2959

Open
aktech opened this issue Feb 12, 2025 · 0 comments
Open

[ENH] - Relax Ingress Check When Using DNS Challenge #2959

aktech opened this issue Feb 12, 2025 · 0 comments

Comments

@aktech
Copy link
Member

aktech commented Feb 12, 2025

Feature description

  • Relax the ingress check when acme_challenge_type=dns is used.
  • Optionally, provide a warning instead of a hard failure if the ingress DN is not resolvable.

This is relevant after #2957 is merged.

Value and/or benefit

Currently, Nebari enforces an ingress check that requires a valid DNS resolution (to ingress IP) before proceeding with deploying anything after the kubernetes_ingress stage

def check_ingress_dns(stage_outputs: Dict[str, Dict[str, Any]], disable_prompt: bool):

However, when using the DNS Challenge for Let's Encrypt, this check is not required since the certificate issuance does not rely on the ingress IP pointing to DNS record, but rather on just the DNS records.

This can be overly restrictive because when deploying Nebari in a private network, the DNS may not always point to the ingress IP address, like say there is a custom proxy in between:

    +-------------+
    |  DNS Record |
    +-------------+
           |
           v
    +---------------+
    |  Custom Proxy |
    +---------------+
           |
           v
    +-------------+
    |  Ingress IP |
    +-------------+
           |
           v
+-------------------+
|  Private Network  |
+-------------------+

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

No branches or pull requests

1 participant