Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 3 missing UnitTests ColorConversion - brightness #16

Open
Chris53897 opened this issue Aug 28, 2022 · 0 comments
Open

Fix the 3 missing UnitTests ColorConversion - brightness #16

Chris53897 opened this issue Aug 28, 2022 · 0 comments
Assignees

Comments

@Chris53897
Copy link
Collaborator

There are actual 3 UnitTests that are failing.
https://github.com/neoteknic/Phue/runs/8056721561?check_suite_focus=true

These are all linked to the new option $bri (brightness)
https://github.com/neoteknic/Phue/blob/master/library/Phue/Helper/ColorConversion.php#L74

@neoteknic Can you please fix these as i do not know what the expected output is with the new variable?
But with the default value (null?) the result should have the same result as the original PhpUnit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants