Skip to content

bug(workspace): 'Double-click to rename' tooltip shows on folders too — but dblclick on a folder navigates, doesn't rename #1710

@nesquena-hermes

Description

@nesquena-hermes

Summary

The workspace file tree shows a title tooltip "Double-click to rename" on every row — including folders. But folders don't rename on double-click; they navigate (loadDir()). The tooltip is misleading on directory rows.

Reported in the WebUI Discord testers thread by @Deor (May 5 2026), responding to the #1698 fix:

Ah that works yeah. May want to change the popup text as it also says double click at the moment.

(Screenshot: hovering "temp" folder row shows the same "Double-click to rename" popup that files get.)

Current behaviour

static/ui.js:5704 — tooltip is set unconditionally:

nameEl.className = 'file-name';
nameEl.textContent = item.name;
nameEl.title = t('double_click_rename');  // ← attached to dirs too

nameEl.ondblclick (line 5719) then branches on item.type === 'dir' and calls loadDir(item.path) — folder rename is NOT actually wired up here. (Folder rename lives in the right-click context menu via _inlineRenameFileItem(item) at line 5798.)

Fix

Gate the tooltip on item.type !== 'dir':

nameEl.className = 'file-name';
nameEl.textContent = item.name;
if (item.type !== 'dir') nameEl.title = t('double_click_rename');

Folders get no tooltip; files keep the hint that matches their dblclick behaviour. The dblclick navigation on folders, and the right-click → Rename context menu on both, are unchanged.

Why not remove the tooltip entirely

@AvidFuturist asked whether to remove it for files too. Keeping it on files is reasonable: dblclick-to-rename is non-obvious on a chat app's workspace pane (vs. a native file manager), and the tooltip is the only discoverability path for users who don't think to right-click. Removing it on folders alone fixes the misleading affordance without losing useful discoverability.

If we want to get rid of it on files too in a follow-up, the i18n key already exists in 9 locales — easy to drop, but I'd argue against until a richer hover surface (multi-line tooltip with both rename + open-preview hints) is in place.

Severity

M3 — minor UX polish, no functional impact, one-line fix. Companion to #1698 / #1702 / #1707 (file-tree click affordances).

Reporter

@Deor via WebUI Discord testers thread (May 5 2026 09:34 UTC).

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions