Applied suggestions

Author: JanVogelsang

.clang-tidy

@@ -1 +1 @@
-Checks: '-*,modernize-use-nullptr,modernize-use-override,bugprone,modernize-redundant-void-arg'
+Checks: '-*,modernize-use-nullptr,modernize-use-override,bugprone,modernize-redundant-void-arg'

doc/htmldoc/static/js/11.1.0_highlight.min.js

@@ -419,7 +419,7 @@ className:"title",begin:u(t)+e.IDENT_RE,relevance:0
 },c=u(t)+e.IDENT_RE+"\\s*\\(",d={
 keyword:["asm","auto","break","case","const","continue","default","do","else","enum","extern","for","fortran","goto","if","inline","register","restrict","return","sizeof","static","struct","switch","typedef","union","volatile","while","_Alignas","_Alignof","_Atomic","_Generic","_Noreturn","_Static_assert","_Thread_local","alignas","alignof","noreturn","static_assert","thread_local","_Pragma"],
 type:["float","double","signed","unsigned","int","short","long","char","void","_Bool","_Complex","_Imaginary","_Decimal32","_Decimal64","_Decimal128","complex","bool","imaginary"],
-literal:"true false nullptr",
+literal:"true false NULL",
 built_in:"std string wstring cin cout cerr clog stdin stdout stderr stringstream istringstream ostringstream auto_ptr deque list queue stack vector map set pair bitset multiset multimap unordered_set unordered_map unordered_multiset unordered_multimap priority_queue make_pair array shared_ptr abort terminate abs acos asin atan2 atan calloc ceil cosh cos exit exp fabs floor fmod fprintf fputs free frexp fscanf future isalnum isalpha iscntrl isdigit isgraph islower isprint ispunct isspace isupper isxdigit tolower toupper labs ldexp log10 log malloc realloc memchr memcmp memcpy memset modf pow printf putchar puts scanf sinh sin snprintf sprintf sqrt sscanf strcat strchr strcmp strcpy strcspn strlen strncat strncmp strncpy strpbrk strrchr strspn strstr tanh tan vfprintf vprintf vsprintf endl initializer_list unique_ptr"
 },g=[o,i,n,e.C_BLOCK_COMMENT_MODE,r,s],b={variants:[{begin:/=/,end:/;/},{
 begin:/\(/,end:/\)/},{beginKeywords:"new throw return else",end:/;/}],

doc/htmldoc/static/js/highlight.min.js

@@ -431,7 +431,7 @@ className:"title",begin:n.optional(a)+e.IDENT_RE,relevance:0
 },d=n.optional(a)+e.IDENT_RE+"\\s*\\(",g={
 keyword:["asm","auto","break","case","continue","default","do","else","enum","extern","for","fortran","goto","if","inline","register","restrict","return","sizeof","struct","switch","typedef","union","volatile","while","_Alignas","_Alignof","_Atomic","_Generic","_Noreturn","_Static_assert","_Thread_local","alignas","alignof","noreturn","static_assert","thread_local","_Pragma"],
 type:["float","double","signed","unsigned","int","short","long","char","void","_Bool","_Complex","_Imaginary","_Decimal32","_Decimal64","_Decimal128","const","static","complex","bool","imaginary"],
-literal:"true false nullptr",
+literal:"true false NULL",
 built_in:"std string wstring cin cout cerr clog stdin stdout stderr stringstream istringstream ostringstream auto_ptr deque list queue stack vector map set pair bitset multiset multimap unordered_set unordered_map unordered_multiset unordered_multimap priority_queue make_pair array shared_ptr abort terminate abs acos asin atan2 atan calloc ceil cosh cos exit exp fabs floor fmod fprintf fputs free frexp fscanf future isalnum isalpha iscntrl isdigit isgraph islower isprint ispunct isspace isupper isxdigit tolower toupper labs ldexp log10 log malloc realloc memchr memcmp memcpy memset modf pow printf putchar puts scanf sinh sin snprintf sprintf sqrt sscanf strcat strchr strcmp strcpy strcspn strlen strncat strncmp strncpy strpbrk strrchr strspn strstr tanh tan vfprintf vprintf vsprintf endl initializer_list unique_ptr"
 },u=[l,r,t,e.C_BLOCK_COMMENT_MODE,o,s],b={variants:[{begin:/=/,end:/;/},{
 begin:/\(/,end:/\)/},{beginKeywords:"new throw return else",end:/;/}],

sli/slitype.h

@@ -86,8 +86,6 @@ class SLIType
   SLIFunction*
   getaction() const
   {
-    // assert(defaultaction);
-    // If this fails, we have created a datum before the types were initialised.
     return defaultaction;
   }
 };

sli/token.h

@@ -373,15 +373,13 @@ class Token
   Datum*
   operator->() const
   {
-    //      assert(p!= nullptr);
     return p;
   }
 
 
   Datum&
   operator*() const
   {
-    //      assert(p);
     return *p;
   }
 

sli/typechk.cc

@@ -167,7 +167,6 @@ TypeTrie::getalternative( TypeTrie::TypeNode* pos, const Name& type )
   if ( pos->type == empty )
   {
     pos->type = type;
-    //    assert(not pos->next);
     return pos;
   }
 
@@ -180,10 +179,8 @@ TypeTrie::getalternative( TypeTrie::TypeNode* pos, const Name& type )
 
     if ( pos->type == sli::any )
     {
-      // any must have been the tail and the previous
-      // if must have added an extra Node, thus the following
-      // assertion must hold:
-      // assert(not pos->alt->alt);
+      // When entering this if, the previous if added an extra Node,
+      // thus pos->alt->alt will not be defined yet (nullptr)
 
       TypeNode* new_tail = pos->alt;
 
@@ -255,7 +252,7 @@ TypeTrie::insert_move( const TypeArray& a, Token& f )
   /* Error conditions:
      1. If pos->next!=NULL, the parameter list overlaps with
      an existing function definition.
-     2. If pos->alt, something undefined must have happened.
+     2. If pos->alt != nullptr, something undefined must have happened.
      This should be impossible.
   */
   if ( not pos->next )