Introduce skipping for mpitests in case of MPI version incompatible with subprocess

Author: heplesser

pyproject.toml

@@ -4,6 +4,7 @@ markers = [
     "skipif_missing_hdf5: skip test if NEST was built without HDF5 support",
     "skipif_missing_mpi: skip test if NEST was built without MPI support",
     "skipif_missing_threads: skip test if NEST was built without multithreading support",
+    "skipif_incompatible_mpi: skip if NEST with built with MPI that does not work with subprocess",
     "simulation: the simulation class to use. Always pass a 2nd dummy argument"
 ]
 

testsuite/pytests/conftest.py

@@ -34,6 +34,7 @@ def test_gsl():
 import dataclasses
 import os
 import pathlib
+import subprocess
 import sys
 
 import nest
@@ -156,6 +157,25 @@ def have_plotting():
         return False
 
 
+@pytest.fixture(scope="session")
+def subprocess_compatible_mpi():
+    """Until at least OpenMPI 4.1.6, the following fails due to a bug in OpenMPI, from 5.0.7 is definitely safe."""
+
+    res = subprocess.run(["mpirun", "-np", "1", "echo"])
+    return res.returncode == 0
+
+
+@pytest.fixture(autouse=True)
+def skipif_incompatible_mpi(request, subprocess_compatible_mpi):
+    """
+    Globally applied fixture that skips tests marked to be skipped when MPI is
+    not compatible with subprocess.
+    """
+
+    if not subprocess_compatible_mpi and request.node.get_closest_marker("skipif_incompatible_mpi"):
+        pytest.skip("skipped because MPI is incompatible with subprocess")
+
+
 @pytest.fixture(autouse=True)
 def simulation_class(request):
     return getattr(request, "param", testsimulation.Simulation)

testsuite/pytests/sli2py_mpi/test_all_to_all.py

@@ -26,6 +26,7 @@
 
 
 # Parametrization over the number of nodes here only to show hat it works
+@pytest.mark.skipif_incompatible_mpi
 @pytest.mark.parametrize("N", [4, 7])
 @MPITestAssertEqual([1, 4], debug=False)
 def test_all_to_all(N):

testsuite/pytests/sli2py_mpi/test_gap_junctions_mpi.py

@@ -19,10 +19,12 @@
 # You should have received a copy of the GNU General Public License
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
-
+import pytest
 from mpi_test_wrapper import MPITestAssertEqual
 
 
+@pytest.mark.skipif_incompatible_mpi
+@pytest.mark.skipif_missing_gsl
 @MPITestAssertEqual([1, 2, 4], debug=False)
 def test_gap_junctions_mpi():
     """

testsuite/pytests/sli2py_mpi/test_issue_1957.py

@@ -19,10 +19,11 @@
 # You should have received a copy of the GNU General Public License
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
-
+import pytest
 from mpi_test_wrapper import MPITestAssertEqual
 
 
+@pytest.mark.skipif_incompatible_mpi
 @MPITestAssertEqual([2, 4])
 def test_issue_1957():
     """

testsuite/pytests/sli2py_mpi/test_issue_2119.py

@@ -32,6 +32,7 @@
 ]
 
 
+@pytest.mark.skipif_incompatible_mpi
 @pytest.mark.parametrize(["kind", "specs"], random_params)
 @MPITestAssertEqual([1, 2, 4])
 def test_issue_2119(kind, specs):

testsuite/pytests/sli2py_mpi/test_issue_281.py

@@ -20,9 +20,11 @@
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
 
+import pytest
 from mpi_test_wrapper import MPITestAssertCompletes
 
 
+@pytest.mark.skipif_incompatible_mpi
 @MPITestAssertCompletes([1, 2, 4])
 def test_issue_281():
     """

testsuite/pytests/sli2py_mpi/test_issue_600.py

@@ -20,9 +20,11 @@
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
 
+import pytest
 from mpi_test_wrapper import MPITestAssertEqual
 
 
+@pytest.mark.skipif_incompatible_mpi
 @MPITestAssertEqual([1, 2, 4], debug=False)
 def test_issue_600():
     """

testsuite/pytests/sli2py_mpi/test_mini_brunel_ps.py

@@ -19,10 +19,11 @@
 # You should have received a copy of the GNU General Public License
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
-
+import pytest
 from mpi_test_wrapper import MPITestAssertEqual
 
 
+@pytest.mark.skipif_incompatible_mpi
 @MPITestAssertEqual([1, 2, 4])
 def test_mini_brunel_ps():
     """

testsuite/pytests/sli2py_mpi/test_self_get_conns_with_empty_ranks.py

@@ -19,13 +19,12 @@
 # You should have received a copy of the GNU General Public License
 # along with NEST.  If not, see <http://www.gnu.org/licenses/>.
 
-import numpy as np
-import pandas
 import pytest
 from mpi_test_wrapper import MPITestAssertEqual
 
 
 # Parametrization over the number of nodes here only to show hat it works
+@pytest.mark.skipif_incompatible_mpi
 @MPITestAssertEqual([1, 2, 4], debug=False)
 def test_self_get_conns_with_empty_ranks():
     """