Final tasks for inclusion of netbox.netbox in Ansible 2.10 (#303)

Author: FragmentedPacket

.gitignore

@@ -4,6 +4,7 @@ __pycache__/
 tests/output/*
 venv/
 .vscode/
+changelogs/.plugin-cache.yaml
 docs/_build/*
 
 # https://github.com/ansible/ansible/issues/68499

.travis.yml

@@ -8,9 +8,9 @@ dist: bionic
 
 env:
   global:
-    - COLLECTION_NAMESPACE: netbox
-    - COLLECTION_NAME: netbox
-    - COLLECTION_VERSION: 1.0.0
+    - COLLECTION_NAMESPACE: "netbox"
+    - COLLECTION_NAME: "netbox"
+    - COLLECTION_VERSION: "1.0.0"
     - secure: "tE6GtwrRU+Kjobx/94xqR2MqM20pHCnrLcHgPzIHA3npdwuA+GjCBiBLTkEEQM4fUWIfzUTyjSr9bZErm1PTI1GcIRdniTgJ3ZzSSkE7tgeYALB/7xsusB57SlmbBQm2SGwU558uWZ3NHEsi0WTgD8GKZo77OpGX72FZKsVXOz6k2wve51sOtoSVjgCsvWTmZHx4ynGdiA5wFkZfaEcjXECahKtunW+MlB5kpJzkVeLRUEXFMhWlsIYiA5nj8OI/X3Nk9ugh1ribENX9LrjpgrqQ9YariZ8G6py1ONuKZIn2g7xs5kNQ3qL6HL6N7SoUxiwH16CfSyugFaYiMfaxQ4NUVGGRHS4vSGbNIf+gLHcYvP40miI1f/+pntCzqygZMhW73FX2o+KH2OGv09khOl8k1nDg2/XvW0kCc/FU6l+Jp5wCC8H9X2uiULtQpRqts5TzIonlPEzGIpfGFgJ5m54Emhv9gjG1Z5OOyL/qae1Wr+L/uhiFafcglZYh8NHEMWCUCkeqFqR2kDmUMtdgYLD7Q7NdwlL/PSVVs1l7UPiQHlnecQKEHN7CvR3eKByTEmkCKafRYh/JQ9rBt9sZc7aAPVu+w3wWUwbHS4o4vVnmyXvJb1PeJSiuynF7CBo4Qd6qj4YwX8gLK6PylGyaMOp169u6xw1mo5/CX0pJ3x4="
 
 jobs:
@@ -28,8 +28,10 @@ jobs:
         - docker-compose pull
         - docker-compose up -d
         - cd ..
+        - pip install -U pip
+        - pip install -U pytest
         - pip install -U pip "setuptools>=46.1.3"
-        - pip install pytest==4.6.5 pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
+        - pip install pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
         - pip install pynetbox cryptography codecov jmespath jsondiff ansible
 
     # Stick to python 3.7 instead of 3.8, as ansible-test sanity is not compatible with 3.7
@@ -47,8 +49,10 @@ jobs:
         - docker-compose pull
         - docker-compose up -d
         - cd ..
+        - pip install -U pip
+        - pip install -U pytest
         - pip install -U pip "setuptools>=46.1.3"
-        - pip install pytest==4.6.5 pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
+        - pip install pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
         - pip install pynetbox cryptography codecov jmespath jsondiff ansible
 
     # Latest development versions of Netbox and Ansible, newest Python
@@ -65,13 +69,37 @@ jobs:
         - docker-compose pull
         - docker-compose up -d
         - cd ..
+        - pip install -U pip
+        - pip install -U pytest
         - pip install -U pip "setuptools>=46.1.3"
-        - pip install pytest==4.6.5 pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
+        - pip install pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
         - pip install pynetbox cryptography jmespath jsondiff
         - git clone https://github.com/ansible/ansible.git
         - cd ansible
         - source hacking/env-setup
         - cd  ..
+
+        # Commenting out, but keeping for next PR to work on sanity issues
+        #- name: "Ansible 2.10 Preparation"
+        #  python: 3.8
+        #  env: INTEGRATION_TESTS=latest
+        #  install:
+        #    - pip install -U pip "setuptools>=46.1.3"
+        #    - pip install pytest==4.6.5 pytest-mock pytest-xdist jinja2 PyYAML black==19.10b0 "coverage<5"
+        #    - pip install pynetbox cryptography jmespath jsondiff ansible-base
+        #  before_script:
+        #    - ls
+        #    - cd ..
+        #    - mkdir -p ~/ansible_collections/$COLLECTION_NAMESPACE
+        #    - cp -R ansible_modules ~/ansible_collections/$COLLECTION_NAMESPACE/$COLLECTION_NAME
+        #    - cd ~/ansible_collections/$COLLECTION_NAMESPACE/$COLLECTION_NAME
+        #    - ansible-galaxy collection build .
+        #    - ansible-galaxy collection install $COLLECTION_NAMESPACE-$COLLECTION_NAME-$COLLECTION_VERSION.tar.gz -p /home/travis/.ansible/collections
+        # Run all further tests from within the installed directory
+        # Required to resolve imports of other collections
+        #- cd /home/travis/.ansible/collections/ansible_collections/$COLLECTION_NAMESPACE/$COLLECTION_NAME
+      #script:
+      #  - ansible-test sanity --docker -v --exclude tests/ --exclude docs/ --skip-test pep8
   allow_failures:
     # When testing against dev netbox and dev ansible, allow failures
     - env: PYTHON_VER=3.8 VERSION=snapshot INTEGRATION_TESTS=latest

CHANGELOG.rst

@@ -0,0 +1,31 @@
+changelog_filename_template: ../CHANGELOG.rst
+changelog_filename_version_depth: 0
+changes_file: changelog.yaml
+changes_format: combined
+ignore_other_fragment_extensions: true
+keep_fragments: false
+mention_ancestor: true
+new_plugins_after_name: removed_features
+notesdir: fragments
+prelude_section_name: release_summary
+prelude_section_title: Release Summary
+sections:
+  - - major_changes
+    - Major Changes
+  - - minor_changes
+    - Minor Changes
+  - - breaking_changes
+    - Breaking Changes / Porting Guide
+  - - deprecated_features
+    - Deprecated Features
+  - - removed_features
+    - Removed Features (previously deprecated)
+  - - security_fixes
+    - Security Fixes
+  - - bugfixes
+    - Bugfixes
+  - - known_issues
+    - Known Issues
+title: Netbox.Netbox
+trivial_section_name: trivial
+use_fqcn: true

changelogs/changelog.yaml

@@ -47,10 +47,10 @@ tags:
 # range specifiers can be set and are separated by ','
 dependencies:
   # Required for ipaddress python library
-  ansible.netcommon: "*"
+  ansible.netcommon: ">=1.0.0"
 
   # Required for json_query used in lookup plugin integration tests
-  community.general: "*"
+  community.general: ">=1.0.0"
 
 # The URL of the originating SCM repository
 repository: https://github.com/netbox-community/ansible_modules

changelogs/config.yaml

@@ -0,0 +1,6 @@
+---
+requires_ansible: ">=2.9.10"
+plugin_routing:
+  modules:
+    netbox_interface:
+      redirect: netbox.netbox.plugins.modules.netbox_device_interface