Enhancement: nb_inventory - group_by for services (#310)

Author: FragmentedPacket

plugins/inventory/nb_inventory.py

@@ -127,6 +127,7 @@
                 - cluster_type
                 - cluster_group
                 - is_virtual
+                - services
             default: []
         group_names_raw:
             description: Will not add the group_by choice name to the group names
@@ -1066,6 +1067,11 @@ def generate_group_name(self, grouping, group):
                 # Don't create the inverse group
                 return None
 
+        # Special case. Extract name from service, which is a hash.
+        if grouping == "services":
+            group = group["name"]
+            grouping = "service"
+
         if self.group_names_raw:
             return group
         else:

tests/integration/targets/inventory/files/test-inventory.json

@@ -736,6 +736,9 @@
             "region_other_region",
             "region_parent_region",
             "role_core_switch",
+            "service_http",
+            "service_ssh",
+            "service_telnet",
             "site_test_site2",
             "ungrouped"
         ]
@@ -825,6 +828,22 @@
             "test100"
         ]
     },
+    "service_ssh": {
+        "hosts": [
+            "Test VM With Spaces",
+            "test100"
+        ]
+    },
+    "service_http": {
+        "hosts": [
+            "test100"
+        ]
+    },
+    "service_telnet": {
+        "hosts": [
+            "Test Nexus One"
+        ]
+    },
     "site_test_site": {
         "hosts": [
             "Test Nexus One",

tests/integration/targets/inventory/files/test-inventory.yml

@@ -22,3 +22,4 @@ group_by:
   - cluster_group
   - cluster_type
   - is_virtual
+  - services