Skip to content

Closes #19891: Bulk operation jobs #19897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 18, 2025
Merged

Conversation

jeremystretch
Copy link
Member

Closes: #19891

  • Adopt fix for bug No entry point exists to mark a background job as failed #19806 in v4.3.4
  • Refactor base bulk edit forms
  • Add background_job toggle to BulkEditForm and BulkDeleteForm via BackgroundJobMixin
  • Extend BulkEditView & BulkDeleteView to support background jobs
  • Move the attachment of a success message to process_request_as_job()

@jeremystretch jeremystretch marked this pull request as ready for review July 17, 2025 13:06
@jeremystretch jeremystretch requested a review from jnovinger July 17, 2025 13:06
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this has a fair amount of surface area, so wanted to give it some attention while poking at it. Everything seems to work very well. I only noticed one potentially unexpected behavior.

When invoking bulk edit or bulk delete for for objects in a sub-table (think: viewing interfaces of a device, via the device's detail view), you're dumped back in the generic list view for the item type being edited/deleted.

So, I have a switch. I select multiple interfaces from /dcim/devices/<device pk>/interfaces/ and click bulk edit/delete. I then select background job and submit. I get redirected to /dcim/interfaces/.

@jeremystretch
Copy link
Member Author

When invoking bulk edit or bulk delete for for objects in a sub-table (think: viewing interfaces of a device, via the device's detail view), you're dumped back in the generic list view for the item type being edited/deleted.

I think this is actually a regression introduced under #19735; it occurs in the current feature branch as well. I considered tackling it as part of this PR, but it probably requires changes to form controls outside the scope of the associated FR. I've opened bug #19911 to address this separately.

@jnovinger jnovinger merged commit cebc56e into feature Jul 18, 2025
6 checks passed
@jnovinger jnovinger deleted the 19891-bulk-operation-jobs branch July 18, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants