Skip to content

Commit d533ce0

Browse files
authored
[pylint] prepping for enabling pylint for non-errors (apache#4884)
1 parent caa7267 commit d533ce0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+41
-3
lines changed

.pylintrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ confidence=
6565
# --enable=similarities". If you want to run only the classes checker, but have
6666
# no Warning level messages displayed, use"--disable=all --enable=classes
6767
# --disable=W"
68-
disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type
68+
disable=standarderror-builtin,long-builtin,dict-view-method,intern-builtin,suppressed-message,no-absolute-import,unpacking-in-except,apply-builtin,delslice-method,indexing-exception,old-raise-syntax,print-statement,cmp-builtin,reduce-builtin,useless-suppression,coerce-method,input-builtin,cmp-method,raw_input-builtin,nonzero-method,backtick,basestring-builtin,setslice-method,reload-builtin,oct-method,map-builtin-not-iterating,execfile-builtin,old-octal-literal,zip-builtin-not-iterating,buffer-builtin,getslice-method,metaclass-assignment,xrange-builtin,long-suffix,round-builtin,range-builtin-not-iterating,next-method-called,dict-iter-method,parameter-unpacking,unicode-builtin,unichr-builtin,import-star-module-level,raising-string,filter-builtin-not-iterating,old-ne-operator,using-cmp-argument,coerce-builtin,file-builtin,old-division,hex-method,invalid-unary-operand-type,missing-docstring,too-many-lines,duplicate-code
6969

7070

7171
[REPORTS]

superset/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Package's main module!"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/cache_util.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/cli.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/usr/bin/env python
22
# -*- coding: utf-8 -*-
3+
# pylint: disable=C,R,W
34
from __future__ import absolute_import
45
from __future__ import division
56
from __future__ import print_function

superset/config.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""The main config file for Superset
34
45
All configuration in this file can be overridden by providing a superset_config

superset/connectors/base/models.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/connectors/base/views.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/connectors/connector_registry.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/connectors/druid/models.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
# pylint: disable=invalid-unary-operand-type
34
from __future__ import absolute_import
45
from __future__ import division

superset/connectors/druid/views.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/connectors/sqla/models.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/connectors/sqla/views.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Views used by the SqlAlchemy connector"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/data/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
"""Loads datasets, dashboards and slices in a new superset instance"""
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/dataframe.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
""" Superset wrapper around pandas.DataFrame.
34
45
TODO(bkyryliuk): add support for the conventions like: *_dim or dim_*

superset/db_engine_specs.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Compatibility layer for different database engines
34
45
This modules stores logic specific to different database engines. Things

superset/db_engines/hive.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/dict_import_export_util.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/exceptions.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# -*- coding: utf-8 -*-
2-
2+
# pylint: disable=C,R,W
33
from __future__ import absolute_import
44
from __future__ import division
55
from __future__ import print_function

superset/extract_table_names.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#!/usr/bin/env python
22
# -*- coding: utf-8 -*-
3+
# pylint: disable=C,R,W
34
#
45
# Copyright (C) 2016 Andi Albrecht, [email protected]
56
#

superset/forms.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Contains the logic to create cohesive forms on the explore view"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/import_util.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/jinja_context.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Defines the templating context for SQL Lab"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/legacy.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Code related with dealing with legacy / change management"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/migrations/env.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import with_statement
34

45
import logging

superset/models/annotations.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""a collection of Annotation-related models"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/models/core.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""A collection of ORM sqlalchemy models for Superset"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/models/helpers.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""a collection of model-related helper classes and functions"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/models/sql_lab.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""A collection of ORM sqlalchemy models for SQL Lab"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/security.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""A set of constants and methods to manage permissions and security"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/sql_lab.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/sql_parse.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/stats_logger.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/translations/utils.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/utils.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""Utility functions used across Superset"""
34
from __future__ import absolute_import
45
from __future__ import division

superset/views/annotations.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/views/base.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/views/core.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/views/sql_lab.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/views/utils.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
from __future__ import absolute_import
34
from __future__ import division
45
from __future__ import print_function

superset/viz.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# -*- coding: utf-8 -*-
2+
# pylint: disable=C,R,W
23
"""This module contains the 'Viz' objects
34
45
These objects represent the backend of all the visualizations that

tox.ini

+1-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ deps =
6767

6868
[testenv:pylint]
6969
commands =
70-
pylint superset --errors-only
70+
pylint superset
7171
deps =
7272
-rrequirements.txt
7373
-rrequirements-dev.txt

0 commit comments

Comments
 (0)