tests: some tests fixed to work with SQL Server

Author: dg

tests/Database/Table/Selection.insert().phpt

@@ -49,24 +49,27 @@ if ($driverName !== 'sqlsrv') {
 }
 
 
-switch ($driverName) {
-	case 'mysql':
-		$selection = $context->table('author')->select('NULL, id, NULL, CONCAT(?, name), NULL',  'Biography: ');
-		break;
-	case 'pgsql':
-		$selection = $context->table('author')->select('nextval(?), id, NULL, ? || name, NULL', 'book_id_seq', 'Biography: ');
-		break;
-	case 'sqlite':
-		$selection = $context->table('author')->select('NULL, id, NULL, ? || name, NULL', 'Biography: ');
-		break;
-	case 'sqlsrv':
-		$selection = $context->table('author')->select('id, NULL, CONCAT(?, name), NULL', 'Biography: ');
-		break;
-	default:
-		Assert::fail("Unsupported driver $driverName");
+// SQL Server 2008 doesn't know CONCAT()
+if ($driverName !== 'sqlsrv') {
+	switch ($driverName) {
+		case 'mysql':
+			$selection = $context->table('author')->select('NULL, id, NULL, CONCAT(?, name), NULL',  'Biography: ');
+			break;
+		case 'pgsql':
+			$selection = $context->table('author')->select('nextval(?), id, NULL, ? || name, NULL', 'book_id_seq', 'Biography: ');
+			break;
+		case 'sqlite':
+			$selection = $context->table('author')->select('NULL, id, NULL, ? || name, NULL', 'Biography: ');
+			break;
+		case 'sqlsrv':
+			$selection = $context->table('author')->select('id, NULL, CONCAT(?, name), NULL', 'Biography: ');
+			break;
+		default:
+			Assert::fail("Unsupported driver $driverName");
+	}
+	$context->table('book')->insert($selection);
+	Assert::equal(4, $context->table('book')->where('title LIKE', 'Biography%')->count('*'));
 }
-$context->table('book')->insert($selection);
-Assert::equal(4, $context->table('book')->where('title LIKE', 'Biography%')->count('*'));
 
 
 // Insert into table without primary key

tests/Database/Table/Selection.page().phpt

@@ -9,6 +9,10 @@ use Tester\Assert;
 
 require __DIR__ . '/../connect.inc.php'; // create $connection
 
+if ($driverName === 'sqlsrv' && $connection->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION) < 11) {
+	Tester\Environment::skip('Offset is supported since SQL Server 2012');
+}
+
 Nette\Database\Helpers::loadFromFile($connection, __DIR__ . "/../files/{$driverName}-nette_test1.sql");
 
 //public function page($page, $itemsPerPage, & $numOfPages = NULL)
@@ -54,7 +58,10 @@ test(function () use ($context) { //less items than $itemsPerPage
 	Assert::equal(4, count($tags)); //all four items from db
 });
 
-test(function () use ($context) { //invalid params
-	$tags = $context->table('tag')->page('foo', 'bar');
-	Assert::equal(0, count($tags)); //no items
-});
+// SQL Server throw PDOException 'The number of rows provided for a FETCH clause must be greater then zero.'
+if ($driverName !== 'sqlsrv') {
+	test(function () use ($context) { //invalid params
+		$tags = $context->table('tag')->page('foo', 'bar');
+		Assert::equal(0, count($tags)); //no items
+	});
+}

tests/Database/Table/Table.limit.sqlsrv.phpt

@@ -11,35 +11,55 @@ require __DIR__ . '/../connect.inc.php'; // create $connection
 
 Nette\Database\Helpers::loadFromFile($connection, __DIR__ . "/../files/{$driverName}-nette_test1.sql");
 
+$version2008 = $connection->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION) < 11;
 
 Assert::same(
-	'SELECT TOP 2 * FROM [author]',
+	$version2008
+		? 'SELECT TOP 2 * FROM [author] ORDER BY [author].[id]'
+		: 'SELECT * FROM [author] ORDER BY [author].[id] OFFSET 0 ROWS FETCH NEXT 2 ROWS ONLY',
 	$context->table('author')->limit(2)->getSql()
 );
 
-Assert::exception(function () use ($context) {
-	$context->table('author')->limit(2, 10)->getSql();
-}, Nette\NotSupportedException::class, 'Offset is not supported by this database.');
-
 Assert::same(
-	'SELECT TOP 2 * FROM [author] ORDER BY [name]',
+	$version2008
+		? 'SELECT TOP 2 * FROM [author] ORDER BY [name]'
+		: 'SELECT * FROM [author] ORDER BY [name] OFFSET 0 ROWS FETCH NEXT 2 ROWS ONLY',
 	$context->table('author')->order('name')->limit(2)->getSql()
 );
 
 Assert::same(
-	'SELECT TOP 10 * FROM [author]',
+	$version2008
+		? 'SELECT TOP 10 * FROM [author] ORDER BY [author].[id]'
+		: 'SELECT * FROM [author] ORDER BY [author].[id] OFFSET 0 ROWS FETCH NEXT 10 ROWS ONLY',
 	$context->table('author')->page(1, 10)->getSql()
 );
 
 Assert::same(
-	'SELECT TOP 10 * FROM [author]',
+	$version2008
+		? 'SELECT TOP 0 * FROM [author] ORDER BY [author].[id]'
+		: 'SELECT * FROM [author] ORDER BY [author].[id] OFFSET 0 ROWS FETCH NEXT 0 ROWS ONLY',
 	$context->table('author')->page(0, 10)->getSql()
 );
 
-Assert::exception(function () use ($context) {
-	$context->table('author')->page(2, 10, $count)->getSql();
-}, Nette\NotSupportedException::class, 'Offset is not supported by this database.');
+if ($version2008) {
+	Assert::exception(function () use ($context) {
+		$context->table('author')->page(2, 10, $count)->getSql();
+	}, Nette\NotSupportedException::class, 'Offset is not supported by this database.');
+
+	Assert::exception(function () use ($context) {
+		$context->table('author')->page(2, 2, $count)->getSql();
+	}, Nette\NotSupportedException::class, 'Offset is not supported by this database.');
+
+} else {
+	Assert::same(
+		reformat('SELECT * FROM [author] ORDER BY [author].[id] OFFSET 10 ROWS FETCH NEXT 10 ROWS ONLY'),
+		$context->table('author')->page(2, 10, $count)->getSql()
+	);
+	Assert::same(1, $count);
 
-Assert::exception(function () use ($context) {
-	$context->table('author')->page(2, 2, $count)->getSql();
-}, Nette\NotSupportedException::class, 'Offset is not supported by this database.');
+	Assert::same(
+		reformat('SELECT * FROM [author] ORDER BY [author].[id] OFFSET 2 ROWS FETCH NEXT 2 ROWS ONLY'),
+		$context->table('author')->page(2, 2, $count)->getSql()
+	);
+	Assert::same(2, $count);
+}

tests/Database/Table/Table.placeholders.phpt

@@ -76,7 +76,11 @@ test(function () use ($context, $driverName) {
 });
 
 
-test(function () use ($context) { // Test placeholder for GroupedSelection
+test(function () use ($context, $driverName) { // Test placeholder for GroupedSelection
+	if ($driverName === 'sqlsrv') { // This syntax is not supported on SQL Server
+		return;
+	}
+
 	$books = $context->table('author')->get(11)->related('book')->order('title = ? DESC', 'Test');
 	foreach ($books as $book) {}
 

tests/Database/Table/Table.update().phpt

@@ -74,10 +74,13 @@ $tag2 = $context->table('tag')->insert([
 	'name' => 'PS4 Game',
 ]);  // INSERT INTO `tag` (`name`) VALUES ('PS4 Game')
 
-$tag2->update([
-	'id' => 1,
-]);  // UPDATE `tag` SET `id`=1 WHERE (`id` = (?))
-Assert::same(1, $tag2->id);
+// SQL Server throw PDOException because does not allow to update identity column
+if ($driverName !== 'sqlsrv') {
+	$tag2->update([
+		'id' => 1,
+	]);  // UPDATE `tag` SET `id`=1 WHERE (`id` = (?))
+	Assert::same(1, $tag2->id);
+}
 
 
 $book_tag = $context->table('book_tag')->get([

tests/Database/Table/bugs/bug1356.phpt

@@ -24,4 +24,9 @@ foreach ($books as $book) {
 	$book->title;
 }
 
-Assert::same(reformat('SELECT * FROM [book] ORDER BY [book].[id] LIMIT 1'), $books->getSql());
+Assert::same(reformat([
+	'sqlsrv' => $connection->getPdo()->getAttribute(PDO::ATTR_SERVER_VERSION) < 11
+		? 'SELECT TOP 1 * FROM [book] ORDER BY [book].[id]'
+		: 'SELECT * FROM [book] ORDER BY [book].[id] OFFSET 0 ROWS FETCH NEXT 1 ROWS ONLY',
+	'SELECT * FROM [book] ORDER BY [book].[id] LIMIT 1',
+]), $books->getSql());