Pin fancylog. #641
Open
Pin fancylog. #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamltyson
reviewed
Dec 1, 2025
pyproject.toml
Outdated
Comment on lines
29
to
30
| "fancylog >= 0.7.0; python_version >= '3.11'", | ||
| "fancylog < 5; python_version < '3.11'", |
Member
There was a problem hiding this comment.
Why <5 when we're on 0.7.0? Why not just make it >0.7.0 across all python versions?
Member
Author
There was a problem hiding this comment.
I thought I saw that the dependency resolver failed and installed older versions of fancylog for old versions of python. But I think I might have made this up 🤔 will do a quick check now
Member
There was a problem hiding this comment.
By why <5 when we haven't even released v1? 🤣
Member
Author
There was a problem hiding this comment.
I didn't even notice that 😂 it should be 0.5.0, I think it still worked because fancylog 0.5.0 doesn't support python 3.9 or 3.10 (?, just checking) and so it installs <0.5.0 on these runners and is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to #635 this PR pins fancylog to avoid the release in which package versions was logged by default, that included a subprocess call. This slowed down tests a lot. Tests are now running at their usual duration.
TODO: reverse CI changes before merging