Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering EDA peaks in long signals #1003

Open
manasa-kalanadhabhatta opened this issue Jun 29, 2024 · 3 comments
Open

Filtering EDA peaks in long signals #1003

manasa-kalanadhabhatta opened this issue Jun 29, 2024 · 3 comments
Labels
wontfix This will not be worked on

Comments

@manasa-kalanadhabhatta
Copy link

Describe the solution you'd like
When using the kim2004 (and possibly neurokit) method in eda_peaks(), the min amplitude threshold of 10% for filtering SCR peaks is based on the maximum peak amplitude in the entire signal. This makes sense for a signal that is a few seconds long (like the 50s windows in Kim et al.). However, for arbitrarily long signals (> few minutes), this filters out valid peaks if the peak amplitudes change with time or if there are signal artifacts that are recognized as the largest peak.

How could we do it?
Filtering peaks should be done based on local maxima, possibly using a sliding window. Or, it could be useful to update the documentation to recommend applying eda_peaks() on smaller chunks when dealing with longer signals.

Copy link

welcome bot commented Jun 29, 2024

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

@DominiqueMakowski
Copy link
Member

That sounds like a good idea. Would you mind making a PR to mention this in the function documentation?

Copy link

stale bot commented Jan 31, 2025

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants