Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSP_Amplitude_Mean is missing from the return values #961

Open
michalgnacek opened this issue Feb 7, 2024 · 1 comment
Open

RSP_Amplitude_Mean is missing from the return values #961

michalgnacek opened this issue Feb 7, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@michalgnacek
Copy link

As of #873
the rsp_intervalrelated no longer returns 'RSP_Amplitude_Mean' as incorrectly indicated by the function description and the documentation.

original code:
if "RSP_Amplitude" in colnames: output["RSP_Amplitude_Mean"] = np.nanmean(data["RSP_Amplitude"].values)

was changed to:
if "RSP_Amplitude" in colnames: rav = rsp_rav(data["RSP_Amplitude"].values, peaks=data) output.update(rav.to_dict(orient="records")[0])

This code seems to be using RSP amplitude to calculate a number of RAV features but the amplitude mean itself is not returned. I thought that perhaps one of the rsp_rav return values is an amplitude mean but from what I understand, RAV_mean and amplitude mean are two different values.

Apologies if I missed something and this is working as intended.

Copy link

stale bot commented Feb 1, 2025

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant