Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_find_artifacts and zero threshold from _compute_threshold #962

Open
pvasilek opened this issue Feb 7, 2024 · 4 comments
Open

_find_artifacts and zero threshold from _compute_threshold #962

pvasilek opened this issue Feb 7, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@pvasilek
Copy link

pvasilek commented Feb 7, 2024

Hello,

neurokit2\signal\signal_fixpeaks.py:307: RuntimeWarning: divide by zero encountered in divide
  mrrs /= th2
neurokit2\signal\signal_fixpeaks.py:307: RuntimeWarning: invalid value encountered in divide
  mrrs /= th2

happens when the signal is very noisy so only a few peaks are detected over a long period.
It is just a warning but may require special handling.

- OS: Windows (WindowsPE 64bit)
- Python: 3.12.2
- NeuroKit2: 0.2.7

- NumPy: 1.26.4
- Pandas: 2.2.0
- SciPy: 1.12.0
- sklearn: 1.4.0
- matplotlib: 3.8.2
Copy link

welcome bot commented Feb 7, 2024

Hi 👋 Thanks for reaching out and opening your first issue here! We'll try to come back to you as soon as possible. ❤️ kenobi

@mrpaulstone
Copy link

I'm also having this issue - I'm wondering if a more descriptive warning saying "noisy signal detected" might be an improvement?

@DominiqueMakowski
Copy link
Member

I'm wondering if a more descriptive warning saying "noisy signal detected" might be an improvement?

That'd be nice but I'm not sure how to detect that reliably

Copy link

stale bot commented Jan 31, 2025

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants