debug windows ci failure

Author: eduardorittner

fixture-data/src/nextest_tests.rs

@@ -48,7 +48,7 @@ pub static EXPECTED_TEST_SUITES: LazyLock<IdOrdMap<TestSuiteFixture>> = LazyLock
                     TestCaseFixtureStatus::IgnoredPass,
                 ),
                 TestCaseFixture::new(
-                    "test_slow_timeout_flaky_mod_4",
+                    "test_flaky_slow_timeout_mod_4",
                     TestCaseFixtureStatus::IgnoredFail
                 ),
                 TestCaseFixture::new("test_stdin_closed", TestCaseFixtureStatus::Pass),

fixtures/nextest-tests/tests/basic.rs

@@ -321,7 +321,7 @@ fn test_slow_timeout_subprocess() {
 
 #[test]
 #[ignore]
-fn test_slow_timeout_flaky_mod_4() {
+fn test_flaky_slow_timeout_mod_4() {
     let nextest_attempt = nextest_attempt();
     if nextest_attempt % 4 != 0 {
         panic!("Failed because attempt {} % 4 != 0", nextest_attempt)

nextest-runner/src/reporter/displayer/snapshots/nextest_runner__reporter__displayer__progress__tests__one_timed_out_success_one_failure_with_cancel_reason.snap

@@ -0,0 +1,5 @@
+---
+source: nextest-runner/src/reporter/displayer/progress.rs
+expression: s
+---
+  Cancelling [ 34:17:36] 10/20: 10 running, 0 passed, 1 timed out, 0 skipped

nextest-runner/src/reporter/displayer/snapshots/nextest_runner__reporter__displayer__progress__tests__one_timed_out_success_one_failure_without_cancel_reason.snap

@@ -0,0 +1,5 @@
+---
+source: nextest-runner/src/reporter/displayer/progress.rs
+expression: s
+---
+     Running [ 34:17:36] 10/20: 10 running, 0 passed, 1 timed out, 0 skipped

nextest-runner/tests/integration/basic.rs

@@ -157,12 +157,12 @@ fn test_timeout_with_retries() -> Result<()> {
 }
 
 #[test]
-fn test_timeout_with_flaky_tests() -> Result<()> {
+fn test_timeout_with_flaky() -> Result<()> {
     test_init();
 
     let pcx = ParseContext::new(&PACKAGE_GRAPH);
     let expr = Filterset::parse(
-        "test(test_slow_timeout_flaky_mod_4)".to_owned(),
+        "test(test_flaky_slow_timeout_mod_4)".to_owned(),
         &pcx,
         FiltersetKind::Test,
     )
@@ -203,15 +203,15 @@ fn test_timeout_with_flaky_tests() -> Result<()> {
 
     let (_, instance_value) = instance_statuses
         .iter()
-        .find(|&(&(_, name), _)| name == "test_slow_timeout_flaky_mod_4")
+        .find(|&(&(_, name), _)| name == "test_flaky_slow_timeout_mod_4")
         .unwrap_or_else(|| panic!("test_flaky_mod_4 should be present"));
 
     match &instance_value.status {
         InstanceStatus::Skipped(_) => panic!("test_flaky_mod_4 should have been run"),
         InstanceStatus::Finished(run_statuses) => {
             assert!(
                 run_statuses.len() == 4,
-                "test_slow_timeout_flaky_mod_4 should have been run 4 times, was run {} times",
+                "test_flaky_slow_timeout_mod_4 should have been run 4 times, was run {} times",
                 run_statuses.len()
             );
 
@@ -971,8 +971,13 @@ fn test_override_timeout_result() -> Result<()> {
 
     let (instance_statuses, run_stats) = execute_collect(runner);
 
-    assert_eq!(run_stats.passed_timed_out, 1, "only 1 test should pass");
-    assert_eq!(run_stats.failed_timed_out, 2, "only 2 tests should fail");
+    println!("{instance_statuses:?}");
+    assert_eq!(run_stats.finished_count, 3, "4 tests should have finished");
+    assert_eq!(
+        run_stats.passed_timed_out, 1,
+        "1 test should pass with timeout"
+    );
+    assert_eq!(run_stats.failed_timed_out, 2, "2 tests should fail");
 
     for test_name in [
         "test_slow_timeout",
@@ -997,7 +1002,7 @@ fn test_override_timeout_result() -> Result<()> {
                     "{test_name} should have taken less than 5 seconds, actually took {:?}",
                     run_status.time_taken
                 );
-                if test_name == "test_slow_timeout" {
+                if matches!(test_name, "test_slow_timeout") {
                     (
                         ExecutionResult::Timeout {
                             result: SlowTimeoutResult::Pass,