-
Notifications
You must be signed in to change notification settings - Fork 487
Make lane Column Optional in Samplesheet
#1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…ple, and workflow logic
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a few nf-test tests? This column is quite important further in the workflow to ensure the right samples are grouped together before duplicate marking and ensureing we are not creating blocking conditions on the grouping
thanks @FriederikeHanssen for checking, i have not done this before but i can give it a go, is there some tutorial to follow? |
|
maybe check how we implement tests for other fucntionality in the pipeline in the tests/ folder. for a general introcution to nf-test, you can follow the training here: https://training.nextflow.io/latest/side_quests/nf-test/ It's obviously a lot simpler than how we use the testing but a good introduction to the general concepts. |
|
Thanks for the pointers @FriederikeHanssen , i tried to intall nf-test via |
Addressing the issue raised in #1942
Key changes:
lane.laneis optional; examples revised.lane; kept optional example.lane.Testing:
Pipeline tested without
laneand it work as expected 🤞