Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash when adding ontologies if not a proper meta.yml #3503

Merged
merged 6 commits into from
Mar 26, 2025

Conversation

toniher
Copy link

@toniher toniher commented Mar 24, 2025

I noticed the problem when running:

 nf-core -v modules lint --fix diamond/blastp

It simply presents a warning pointing to the involved channel and elements.

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.95%. Comparing base (6421bab) to head (37018cc).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/modules/lint/__init__.py 30.00% 7 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@toniher
Copy link
Author

toniher commented Mar 26, 2025

@nf-core-bot fix linting

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@toniher toniher merged commit 3ee0bea into nf-core:dev Mar 26, 2025
95 checks passed
@toniher toniher deleted the fix-problem-diamond branch March 26, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants