Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - add back logo to the README #3504

Merged
merged 8 commits into from
Mar 25, 2025
Merged

Bugfix - add back logo to the README #3504

merged 8 commits into from
Mar 25, 2025

Conversation

nikhil
Copy link

@nikhil nikhil commented Mar 24, 2025

I added back the nf-core tools logo which went missing after version 3

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@nikhil nikhil requested review from mashehu and mirpedrol March 24, 2025 17:14
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.89%. Comparing base (496ae45) to head (f7e39ce).
Report is 9 commits behind head on dev.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
We should keep the github URL instead of using relative paths, you can use the old one even if it won't work until this PR is merged.

@nikhil
Copy link
Author

nikhil commented Mar 25, 2025

Thanks! I reverted the relative link update to use the github URL

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 thank you!

@nikhil nikhil merged commit 6421bab into dev Mar 25, 2025
95 checks passed
@nikhil nikhil deleted the bugfix/add_back_logo branch March 25, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants