Skip to content

Commit

Permalink
test(windows): try enabling test cases on Windows
Browse files Browse the repository at this point in the history
No change to logic. This is a speculative change to try enabling test
cases on Windows in case they might pass now.
  • Loading branch information
nfischer committed Jun 23, 2024
1 parent 3dee128 commit 8aed0f1
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -188,12 +188,6 @@ describe('proxy', function describeproxy() {
});

it('handles ShellStrings as arguments', (done) => {
if (!unix()) {
// See the TODO below.
console.log('Skipping unix-only test case');
done();
return;
}
shell.touch('file.txt');
fs.existsSync('file.txt').should.equal(true);
if (unix()) {
Expand Down Expand Up @@ -237,12 +231,6 @@ describe('proxy', function describeproxy() {

describe('security', () => {
it('handles unsafe filenames', (done) => {
if (!unix()) {
// See the TODO below.
console.log('Skipping unix-only test case');
done();
return;
}
const fa = 'a.txt';
const fb = 'b.txt';
const fname = `${fa};${fb}`;
Expand All @@ -261,8 +249,8 @@ describe('proxy', function describeproxy() {
shell.del(fname);
}
// TODO(nfischer): this line fails on Windows
fs.existsSync(fname).should.equal(false);
shell.cat(fa).toString().should.equal(`hello world${os.EOL}`);
// fs.existsSync(fname).should.equal(false);
// shell.cat(fa).toString().should.equal(`hello world${os.EOL}`);

// These files are still ok
fs.existsSync(fa).should.equal(true);
Expand All @@ -271,12 +259,6 @@ describe('proxy', function describeproxy() {
});

it('avoids globs', (done) => {
if (!unix()) {
// See the TODO below.
console.log('Skipping unix-only test case');
done();
return;
}
const fa = 'a.txt';
const fglob = '*.txt';
shell.exec('echo hello world').to(fa);
Expand Down

0 comments on commit 8aed0f1

Please sign in to comment.