Updated github workflows to use script to get iPhone simulator and new checkout@v4

Author: paulsolt-ofsw

.github/workflows/build-test.yml

@@ -14,8 +14,12 @@ jobs:
 
     steps:
     - name: Checkout Repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Install
       run: pod install
     - name: Build & Test
-      run: xcodebuild test -workspace sf-ios.xcworkspace -scheme sf-ios -destination 'platform=iOS Simulator,OS=latest,name=iPhone 16'
+      run: 
+        iphone_names=$(xcrun simctl list devices available --json | jq -r '.devices | to_entries[] | .value[] | select(.name | test("^iPhone [0-9]+")) | .name')
+        latest_iphone=$(echo "$iphone_names" | sort | tail -n 1)
+        echo "latest_iphone: $latest_iphone"
+        xcodebuild test -workspace sf-ios.xcworkspace -scheme sf-ios -destination "platform=iOS Simulator,OS=latest,name=$latest_iphone"

.github/workflows/build.yml

@@ -13,8 +13,12 @@ jobs:
 
     steps:
     - name: Checkout Repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
     - name: Install
       run: pod install
     - name: Build
-      run: xcodebuild build-for-testing -workspace sf-ios.xcworkspace -scheme sf-ios -destination 'platform=iOS Simulator,OS=latest,name=iPhone 16'
+      run: |
+        iphone_names=$(xcrun simctl list devices available --json | jq -r '.devices | to_entries[] | .value[] | select(.name | test("^iPhone [0-9]+")) | .name')
+        latest_iphone=$(echo "$iphone_names" | sort | tail -n 1)
+        echo "latest_iphone: $latest_iphone"
+        xcodebuild build-for-testing -workspace sf-ios.xcworkspace -scheme sf-ios -destination "platform=iOS Simulator,OS=latest,name=$latest_iphone"