Skip to content

Conversation

@ciarams87
Copy link
Contributor

Proposed changes

Problem: As a user of NGF
I want a design to configure NGINX's proxy buffer configuration for my applications through the use of ProxySettingsPolicy
So that I can implement the ProxySettingsPolicy CRD

Solution: Create an implementable ProxySettingsPolicy enhancement proposal

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #4067

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@ciarams87 ciarams87 requested review from a team as code owners November 11, 2025 19:56
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.08%. Comparing base (fc7806a) to head (d2aefe7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4256      +/-   ##
==========================================
- Coverage   86.10%   86.08%   -0.03%     
==========================================
  Files         132      132              
  Lines       14342    14342              
  Branches       35       35              
==========================================
- Hits        12349    12346       -3     
- Misses       1790     1792       +2     
- Partials      203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the docs/proxy-settings-impl branch from dbd2d66 to c8d0a56 Compare November 12, 2025 16:42
Copy link
Contributor

@bjee19 bjee19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ciarams87 ciarams87 force-pushed the docs/proxy-settings-impl branch from c8d0a56 to d2aefe7 Compare November 13, 2025 07:40
@ciarams87 ciarams87 enabled auto-merge (squash) November 13, 2025 07:40
@ciarams87 ciarams87 disabled auto-merge November 13, 2025 08:54
@ciarams87 ciarams87 merged commit e150378 into main Nov 13, 2025
60 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 13, 2025
@ciarams87 ciarams87 deleted the docs/proxy-settings-impl branch November 13, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Design ProxySettingsPolicy API

4 participants