From f918a8b3ba8cd147fabf7b68c8336c09e473605f Mon Sep 17 00:00:00 2001 From: Becca Dawson Date: Wed, 12 Nov 2025 11:52:34 +0000 Subject: [PATCH 01/11] GN-244 update BNFC label in services config --- src/services.json | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/services.json b/src/services.json index 1e7f0ea5..245cf073 100644 --- a/src/services.json +++ b/src/services.json @@ -89,9 +89,9 @@ { "host": "bnfc.nice.org.uk", "landingPath": "/", - "text": "British National Formulary for Children (BNFC)", + "text": "BNF for Children (BNFC)", "abbreviation": "BNFC", - "title": "British National Formulary for Children", + "title": "BNF for Children", "id": "bnfc", "footer": true, "header": true, @@ -149,7 +149,6 @@ "header": false } ], - "internal": [ { "host": "www.nice.org.uk", @@ -173,4 +172,4 @@ ] } ] -} +} \ No newline at end of file From 439c6de46092b01bccd714f00bdeda114386ba66 Mon Sep 17 00:00:00 2001 From: Shilpa Unni Date: Wed, 3 Dec 2025 11:31:59 +0000 Subject: [PATCH 02/11] GN-244 Add non-breaking space for BNFC text --- src/services.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/services.json b/src/services.json index 245cf073..c4ccb34e 100644 --- a/src/services.json +++ b/src/services.json @@ -89,7 +89,7 @@ { "host": "bnfc.nice.org.uk", "landingPath": "/", - "text": "BNF for Children (BNFC)", + "text": "BNF for Children\u00A0(BNF)", "abbreviation": "BNFC", "title": "BNF for Children", "id": "bnfc", @@ -172,4 +172,4 @@ ] } ] -} \ No newline at end of file +} From a00498913e603523cedaf046f5358ad583ceef15 Mon Sep 17 00:00:00 2001 From: Shilpa Unni Date: Wed, 3 Dec 2025 11:32:27 +0000 Subject: [PATCH 03/11] GN-244 Update BNF and BNFC logos --- src/Header/Nav/SubNav/images/bnf.svg | 5 ++- src/Header/Nav/SubNav/images/bnfc.svg | 52 +++------------------------ 2 files changed, 8 insertions(+), 49 deletions(-) diff --git a/src/Header/Nav/SubNav/images/bnf.svg b/src/Header/Nav/SubNav/images/bnf.svg index ea596aa7..d903cee9 100644 --- a/src/Header/Nav/SubNav/images/bnf.svg +++ b/src/Header/Nav/SubNav/images/bnf.svg @@ -1 +1,4 @@ - + + + + \ No newline at end of file diff --git a/src/Header/Nav/SubNav/images/bnfc.svg b/src/Header/Nav/SubNav/images/bnfc.svg index 18247dc2..a5d9080d 100644 --- a/src/Header/Nav/SubNav/images/bnfc.svg +++ b/src/Header/Nav/SubNav/images/bnfc.svg @@ -1,48 +1,4 @@ - - - - - - - - - - - - - - - - - - - - - - - - + + + + \ No newline at end of file From 7777392535cd04607349f4e0c25038d771ca1d65 Mon Sep 17 00:00:00 2001 From: Shilpa Unni Date: Mon, 8 Dec 2025 15:21:42 +0000 Subject: [PATCH 04/11] GN-244 Updated failing snapshots --- src/Footer/__snapshots__/Footer.test.jsx.snap | 8 ++++---- src/Header/__snapshots__/Header.test.jsx.snap | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Footer/__snapshots__/Footer.test.jsx.snap b/src/Footer/__snapshots__/Footer.test.jsx.snap index 1cb10dfe..7c8701a3 100644 --- a/src/Footer/__snapshots__/Footer.test.jsx.snap +++ b/src/Footer/__snapshots__/Footer.test.jsx.snap @@ -107,21 +107,21 @@ exports[`Footer Matches snapshot 1`] = ` href="https://bnfc.nice.org.uk/" > - British National Formulary for Children (BNFC) + BNF for Children (BNF) - British National Formulary for Children + BNF for Children diff --git a/src/Header/__snapshots__/Header.test.jsx.snap b/src/Header/__snapshots__/Header.test.jsx.snap index e8277051..6135afad 100644 --- a/src/Header/__snapshots__/Header.test.jsx.snap +++ b/src/Header/__snapshots__/Header.test.jsx.snap @@ -225,16 +225,16 @@ exports[`Header Matches snapshot 1`] = `
  • - British National Formulary for Children (BNFC) + BNF for Children (BNF)
    • From 04fa07432ec0d6c32e830333fc1a58a90efcafbc Mon Sep 17 00:00:00 2001 From: Shilpa Unni Date: Mon, 8 Dec 2025 15:23:03 +0000 Subject: [PATCH 05/11] GN-244 Update BNF to BNFC --- src/services.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services.json b/src/services.json index c4ccb34e..80a3d5e5 100644 --- a/src/services.json +++ b/src/services.json @@ -89,7 +89,7 @@ { "host": "bnfc.nice.org.uk", "landingPath": "/", - "text": "BNF for Children\u00A0(BNF)", + "text": "BNF for Children\u00A0(BNFC)", "abbreviation": "BNFC", "title": "BNF for Children", "id": "bnfc", From 94a2a520a527eb1ea64840ac951d9029250a6abe Mon Sep 17 00:00:00 2001 From: Shilpa Unni Date: Mon, 8 Dec 2025 15:30:40 +0000 Subject: [PATCH 06/11] GN-244 Update failing snapshots --- src/Footer/__snapshots__/Footer.test.jsx.snap | 2 +- src/Header/__snapshots__/Header.test.jsx.snap | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Footer/__snapshots__/Footer.test.jsx.snap b/src/Footer/__snapshots__/Footer.test.jsx.snap index 7c8701a3..85766c11 100644 --- a/src/Footer/__snapshots__/Footer.test.jsx.snap +++ b/src/Footer/__snapshots__/Footer.test.jsx.snap @@ -109,7 +109,7 @@ exports[`Footer Matches snapshot 1`] = ` - BNF for Children (BNF) + BNF for Children (BNFC)
  • - BNF for Children (BNF) + BNF for Children (BNFC)
    • From 459c0d8ba76351be854e44c36fcf05acd491a453 Mon Sep 17 00:00:00 2001 From: Becca Dawson Date: Tue, 9 Dec 2025 15:27:11 +0000 Subject: [PATCH 07/11] GN-244 update to use no-whitespace version of CKS logo and add padding to subnav image styles --- src/Header/Nav/SubNav/SubNav.module.scss | 1 + src/Header/Nav/SubNav/images/cks.svg | 25 ++++++++++++++++-------- 2 files changed, 18 insertions(+), 8 deletions(-) diff --git a/src/Header/Nav/SubNav/SubNav.module.scss b/src/Header/Nav/SubNav/SubNav.module.scss index 78ddeed8..eca2dee3 100644 --- a/src/Header/Nav/SubNav/SubNav.module.scss +++ b/src/Header/Nav/SubNav/SubNav.module.scss @@ -118,4 +118,5 @@ .image { height: 100%; + padding: utils.rem(spacing.$small + spacing.$x-small); } diff --git a/src/Header/Nav/SubNav/images/cks.svg b/src/Header/Nav/SubNav/images/cks.svg index bd00aead..6de6acba 100644 --- a/src/Header/Nav/SubNav/images/cks.svg +++ b/src/Header/Nav/SubNav/images/cks.svg @@ -1,8 +1,17 @@ - - - - - - + + + + + + + + + \ No newline at end of file From 9ba30e703840b85d215532c6d3f9e8a632e3908b Mon Sep 17 00:00:00 2001 From: Becca Dawson Date: Tue, 9 Dec 2025 16:08:07 +0000 Subject: [PATCH 08/11] GN-244 add unabbreviated 'BNF' to title used to expand BNFC abbreviation for clarity --- src/services.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/services.json b/src/services.json index 80a3d5e5..e9084ce4 100644 --- a/src/services.json +++ b/src/services.json @@ -91,7 +91,7 @@ "landingPath": "/", "text": "BNF for Children\u00A0(BNFC)", "abbreviation": "BNFC", - "title": "BNF for Children", + "title": "British National Formulary for Children", "id": "bnfc", "footer": true, "header": true, @@ -172,4 +172,4 @@ ] } ] -} +} \ No newline at end of file From c5a4e73749f2356fe1955864a141a63b5225dfc4 Mon Sep 17 00:00:00 2001 From: Becca Dawson Date: Tue, 9 Dec 2025 16:08:23 +0000 Subject: [PATCH 09/11] GN-244 add missing L/R padding value for subnav images --- src/Header/Nav/SubNav/SubNav.module.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Header/Nav/SubNav/SubNav.module.scss b/src/Header/Nav/SubNav/SubNav.module.scss index eca2dee3..d103f2a1 100644 --- a/src/Header/Nav/SubNav/SubNav.module.scss +++ b/src/Header/Nav/SubNav/SubNav.module.scss @@ -118,5 +118,5 @@ .image { height: 100%; - padding: utils.rem(spacing.$small + spacing.$x-small); + padding: utils.rem(spacing.$small + spacing.$x-small 0); } From 2d70945d779ffc590808d02bf680afe20cc2a439 Mon Sep 17 00:00:00 2001 From: Becca Dawson Date: Tue, 9 Dec 2025 16:21:20 +0000 Subject: [PATCH 10/11] GN-244 update snapshots to reflect updated abbreviation accessibility text --- src/Footer/__snapshots__/Footer.test.jsx.snap | 6 +++--- src/Header/__snapshots__/Header.test.jsx.snap | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Footer/__snapshots__/Footer.test.jsx.snap b/src/Footer/__snapshots__/Footer.test.jsx.snap index 85766c11..96371889 100644 --- a/src/Footer/__snapshots__/Footer.test.jsx.snap +++ b/src/Footer/__snapshots__/Footer.test.jsx.snap @@ -107,21 +107,21 @@ exports[`Footer Matches snapshot 1`] = ` href="https://bnfc.nice.org.uk/" > BNF for Children (BNFC) - BNF for Children + British National Formulary for Children diff --git a/src/Header/__snapshots__/Header.test.jsx.snap b/src/Header/__snapshots__/Header.test.jsx.snap index f3d95b09..7bde0af8 100644 --- a/src/Header/__snapshots__/Header.test.jsx.snap +++ b/src/Header/__snapshots__/Header.test.jsx.snap @@ -228,7 +228,7 @@ exports[`Header Matches snapshot 1`] = ` data-tracking="BNF for Children (BNFC)" > Date: Tue, 9 Dec 2025 16:31:57 +0000 Subject: [PATCH 11/11] GN-244 prettier:fix --- src/services.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/services.json b/src/services.json index e9084ce4..fea53450 100644 --- a/src/services.json +++ b/src/services.json @@ -172,4 +172,4 @@ ] } ] -} \ No newline at end of file +}