Skip to content

Commit 266af2b

Browse files
committed
Remove outdated code of conduct and contribution docs
Add missing @throws tags Remove unused variables in list
1 parent ded41dd commit 266af2b

File tree

7 files changed

+10
-69
lines changed

7 files changed

+10
-69
lines changed

CODE_OF_CONDUCT.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 0 additions & 60 deletions
This file was deleted.

src/Facebook/FacebookApp.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ public function __serialize(): array
9292

9393
/**
9494
* Unserializes a string as a FacebookApp entity.
95+
* @throws FacebookSDKException
9596
*/
9697
public function unserialize(string $serialized): void
9798
{

src/Facebook/GraphNodes/GraphPage.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424

2525
namespace Facebook\GraphNodes;
2626

27-
use Facebook\FileUpload\FacebookVideo;
28-
2927
/**
3028
* Class GraphPage
3129
*

src/Facebook/Helpers/FacebookSignedRequestFromInputHelper.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,10 @@ abstract class FacebookSignedRequestFromInputHelper
5656
/**
5757
* Initialize the helper and process available signed request data.
5858
*
59-
* @param FacebookApp $app The FacebookApp entity.
60-
* @param FacebookClient $client The client to make HTTP requests.
61-
* @param string|null $graphVersion The version of Graph to use.
59+
* @param FacebookApp $app The FacebookApp entity.
60+
* @param FacebookClient $client The client to make HTTP requests.
61+
* @param string|null $graphVersion The version of Graph to use.
62+
* @throws FacebookSDKException
6263
*/
6364
public function __construct(FacebookApp $app, FacebookClient $client, ?string $graphVersion = null)
6465
{
@@ -71,6 +72,7 @@ public function __construct(FacebookApp $app, FacebookClient $client, ?string $g
7172

7273
/**
7374
* Instantiates a new SignedRequest entity.
75+
* @throws FacebookSDKException
7476
*/
7577
public function instantiateSignedRequest(?string $rawSignedRequest = null): void
7678
{

src/Facebook/Http/GraphRawResponse.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ public function getHttpResponseCode(): ?int
9898
public function setHttpResponseCodeFromHeader(string $rawResponseHeader): void
9999
{
100100
// https://tools.ietf.org/html/rfc7230#section-3.1.2
101-
list($version, $status, $reason) = array_pad(explode(' ', $rawResponseHeader, 3), 3, null);
101+
list(,$status) = array_pad(explode(' ', $rawResponseHeader, 3), 3, null);
102102
$this->httpResponseCode = (int)$status;
103103
}
104104

src/Facebook/SignedRequest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ class SignedRequest
5454
*
5555
* @param FacebookApp $facebookApp The FacebookApp entity.
5656
* @param string|null $rawSignedRequest The raw signed request.
57+
* @throws FacebookSDKException
5758
*/
5859
public function __construct(FacebookApp $facebookApp, ?string $rawSignedRequest = null)
5960
{
@@ -115,6 +116,7 @@ public function hasOAuthData(): bool
115116

116117
/**
117118
* Creates a signed request from an array of data.
119+
* @throws FacebookSDKException
118120
*/
119121
public function make(array $payload): string
120122
{
@@ -131,6 +133,7 @@ public function make(array $payload): string
131133
/**
132134
* Validates and decodes a signed request and saves
133135
* the payload to an array.
136+
* @throws FacebookSDKException
134137
*/
135138
protected function parse(): void
136139
{

0 commit comments

Comments
 (0)