Support for PHP 8.4

[duclt-io]

Hi @nickdnk and contributors,

I am currently using the latest version of php-graph-sdk (v7.0.1), and when running the library with PHP 8.4, I encountered several warnings related to implicitly marking parameters as nullable, which has been deprecated in PHP 8.4.

Specifically, I received the following deprecation warnings:

Deprecated: Facebook\FacebookClient::__construct(): Implicitly marking parameter $httpClientHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/nickdnk/graph-sdk/src/Facebook/FacebookClient.php on line 95

Deprecated: Facebook\HttpClients\FacebookGuzzleHttpClient::__construct(): Implicitly marking parameter $guzzleClient as nullable is deprecated, the explicit nullable type must be used instead in /vendor/nickdnk/graph-sdk/src/Facebook/HttpClients/FacebookGuzzleHttpClient.php on line 44

Deprecated: Facebook\Helpers\FacebookRedirectLoginHelper::__construct(): Implicitly marking parameter $persistentDataHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/nickdnk/graph-sdk/src/Facebook/Helpers/FacebookRedirectLoginHelper.php on line 75

Deprecated: Facebook\Helpers\FacebookRedirectLoginHelper::__construct(): Implicitly marking parameter $urlHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/nickdnk/graph-sdk/src/Facebook/Helpers/FacebookRedirectLoginHelper.php on line 75

These issues occur because PHP 8.4 requires nullable types to be explicitly declared using ?Type instead of relying on implicit inference by the interpreter.

Would you consider updating the library to support PHP 8.4 in an upcoming release?
Thank you for maintaining such an excellent library!

[nickdnk]

Hello

I've been working on adding types to the entire project where applicable. which also fixes the 8.4 deprecation issues. It took a while, but all tests pass now: #9

This also means we'll discontinue PHP 7 support entirely.

I'll probably merge it in and release a version 8.0 sometime next week.

[nickdnk]

Hello @duclt-debughero

Please see the contents of #9. I have released this as 8.0.0-rc1, which I encourage you to try, but please read the changelog to see if you need to make any changes.

All tests pass, so I very much assume it will work, and I will try to deploy it on our own systems and see if I find any issues.

Edit: Changelog here: https://github.com/nickdnk/php-graph-sdk/blob/develop/CHANGELOG.md

[duclt-io]

Hello @nickdnk

Thank you for updating the library to support PHP 8.4! I’ve tested it with version 8.0.0-rc1, and the issue I previously mentioned has been fully resolved.

I really appreciate your quick response and the effort you put into maintaining this library. Thanks for supporting!