name_or_raise for workflow doesn't require project_id (Netflix#3119)

* name_or_raise for workflow doesn't require project_id

* ruff unused import in migration file

Author: wssheldon

src/dispatch/database/revisions/tenant/versions/2023-03-14_b48b245f9c4c.py

@@ -7,7 +7,6 @@
 """
 from alembic import op
 import sqlalchemy as sa
-from sqlalchemy.dialects import postgresql
 
 # revision identifiers, used by Alembic.
 revision = "b48b245f9c4c"
@@ -26,19 +25,10 @@ def upgrade():
         sa.ForeignKeyConstraint(["workflow_id"], ["workflow.id"], ondelete="CASCADE"),
         sa.PrimaryKeyConstraint("signal_id", "workflow_id"),
     )
-    op.create_table(
-        "assoc_signal_instance_tags",
-        sa.Column("signal_instance_id", postgresql.UUID(as_uuid=True), nullable=False),
-        sa.Column("tag_id", sa.Integer(), nullable=False),
-        sa.ForeignKeyConstraint(["signal_instance_id"], ["signal_instance.id"], ondelete="CASCADE"),
-        sa.ForeignKeyConstraint(["tag_id"], ["tag.id"], ondelete="CASCADE"),
-        sa.PrimaryKeyConstraint("signal_instance_id", "tag_id"),
-    )
     # ### end Alembic commands ###
 
 
 def downgrade():
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_table("assoc_signal_instance_tags")
     op.drop_table("assoc_signal_workflows")
     # ### end Alembic commands ###

src/dispatch/signal/service.py

@@ -216,9 +216,7 @@ def create(*, db_session: Session, signal_in: SignalCreate) -> Signal:
 
     workflows = []
     for w in signal_in.workflows:
-        workflow = workflow_service.get_by_name_or_raise(
-            db_session=db_session, project_id=signal.project.id, workflow_in=w
-        )
+        workflow = workflow_service.get_by_name_or_raise(db_session=db_session, workflow_in=w)
         workflows.append(workflow)
 
     signal.workflows = workflows
@@ -285,9 +283,7 @@ def update(*, db_session: Session, signal: Signal, signal_in: SignalUpdate) -> S
 
     workflows = []
     for w in signal_in.workflows:
-        workflow = workflow_service.get_by_name_or_raise(
-            db_session=db_session, project_id=signal.project.id, workflow_in=w
-        )
+        workflow = workflow_service.get_by_name_or_raise(db_session=db_session, workflow_in=w)
         workflows.append(workflow)
 
     signal.workflows = workflows

src/dispatch/workflow/service.py

@@ -34,10 +34,8 @@ def get_by_name(*, db_session, name: str) -> Optional[Workflow]:
     return db_session.query(Workflow).filter(Workflow.name == name).one_or_none()
 
 
-def get_by_name_or_raise(
-    *, db_session: Session, project_id: int, workflow_in=WorkflowRead
-) -> Workflow:
-    workflow = get_by_name(db_session=db_session, project_id=project_id, name=workflow_in.name)
+def get_by_name_or_raise(*, db_session: Session, workflow_in=WorkflowRead) -> Workflow:
+    workflow = get_by_name(db_session=db_session, name=workflow_in.name)
 
     if not workflow:
         raise ValidationError(