From 1158240c9c6a6c7d717990a3f9d6d19900f2f2a4 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Mon, 21 Oct 2024 09:46:19 -0400 Subject: [PATCH 1/4] FIX: Set MRS type to Nifti1Extension for backwards compatibility --- nibabel/nifti1.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nibabel/nifti1.py b/nibabel/nifti1.py index 37f75db10..0a4d25581 100644 --- a/nibabel/nifti1.py +++ b/nibabel/nifti1.py @@ -675,7 +675,7 @@ def _mangle(self, dataset: DicomDataset) -> bytes: (38, 'eval', NiftiExtension), (40, 'matlab', NiftiExtension), (42, 'quantiphyse', NiftiExtension), - (44, 'mrs', NiftiExtension[dict[str, ty.Any]]), + (44, 'mrs', Nifti1Extension), ), fields=('code', 'label', 'handler'), ) From 4c831cf392d2ac3fc21f1a4690a1a2b726c61699 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Mon, 21 Oct 2024 09:46:31 -0400 Subject: [PATCH 2/4] DOC: Add changelog entry --- Changelog | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Changelog b/Changelog index b8e594c29..e00a0cd1f 100644 --- a/Changelog +++ b/Changelog @@ -25,6 +25,17 @@ Eric Larson (EL), Demian Wassermann, Stephan Gerhard and Ross Markello (RM). References like "pr/298" refer to github pull request numbers. +5.3.2 (Monday 21 October 2024) +============================== + +Bug-fix release in the 5.3.x series. + +Bug fixes +--------- +* Restore MRS extension type to Nifti1Extension to maintain backwards compatibility. + (pr/1380) (CM) + + 5.3.1 (Tuesday 15 October 2024) =============================== From af6b74c576d0653015448f97279da9dc081f93bc Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Mon, 21 Oct 2024 09:49:53 -0400 Subject: [PATCH 3/4] DOC: Update changelog to note that .json() is a method --- Changelog | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Changelog b/Changelog index e00a0cd1f..e48fa60ea 100644 --- a/Changelog +++ b/Changelog @@ -57,9 +57,9 @@ NiBabel 6.0 will drop support for Numpy 1.x. New features ------------ -* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and ``.json : dict`` - properties for accessing extension contents. Exceptions will be raised on ``.text`` and ``.json`` if - conversion fails. (pr/1336) (CM) +* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and + ``.json() : dict`` properties/methods for accessing extension contents. + Exceptions will be raised on ``.text`` and ``.json()`` if conversion fails. (pr/1336) (CM) Enhancements ------------ From 56446e5102226f4987621f38628349563467f8c2 Mon Sep 17 00:00:00 2001 From: Chris Markiewicz Date: Wed, 23 Oct 2024 09:33:34 -0400 Subject: [PATCH 4/4] Bump release date --- Changelog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index e48fa60ea..f75ac8bc2 100644 --- a/Changelog +++ b/Changelog @@ -25,8 +25,8 @@ Eric Larson (EL), Demian Wassermann, Stephan Gerhard and Ross Markello (RM). References like "pr/298" refer to github pull request numbers. -5.3.2 (Monday 21 October 2024) -============================== +5.3.2 (Wednesday 23 October 2024) +================================= Bug-fix release in the 5.3.x series.