fix: one more test case, reaching EOF

Author: anibalsolon

nibabel/streamlines/tck.py

@@ -327,14 +327,17 @@ def _read_header(cls, fileobj):
 
             f.fobj.seek(1, os.SEEK_CUR) # Skip \n
 
-            # Read all key-value pairs contained in the header
+            found_end = False
+
+            # Read all key-value pairs contained in the header, stop at EOF
             for n_line, line in enumerate(f.fobj, 1):
                 line = asstr(line).strip()
 
                 if not line: # Skip empty lines
                     continue
 
                 if line == "END": # End of the header
+                    found_end = True
                     break
 
                 if ':' not in line: # Invalid header line
@@ -343,6 +346,9 @@ def _read_header(cls, fileobj):
                 key, value = line.split(":", 1)
                 hdr[key.strip()] = value.strip()
 
+            if not found_end:
+                raise HeaderError("Missing END in the header.")
+
             offset_data = f.tell()
 
             # Set the file position where it was, in case it was previously open

nibabel/streamlines/tests/test_tck.py

@@ -25,8 +25,9 @@ def setup_module():
     global DATA
 
     DATA['empty_tck_fname'] = pjoin(data_path, "empty.tck")
-    DATA['no-magic-number_tck_fname'] = pjoin(data_path, "no-magic-number.tck")
-    DATA['no-header-end_tck_fname'] = pjoin(data_path, "no-header-end.tck")
+    DATA['no_magic_number_tck_fname'] = pjoin(data_path, "no_magic_number.tck")
+    DATA['no_header_end_tck_fname'] = pjoin(data_path, "no_header_end.tck")
+    DATA['no_header_end_eof_tck_fname'] = pjoin(data_path, "no_header_end_eof.tck")
     # simple.tck contains only streamlines
     DATA['simple_tck_fname'] = pjoin(data_path, "simple.tck")
     DATA['simple_tck_big_endian_fname'] = pjoin(data_path,
@@ -56,15 +57,23 @@ def test_load_no_magic_number_file(self):
         for lazy_load in [False, True]:
             with pytest.raises(HeaderError):
                 TckFile.load(
-                    DATA['no-magic-number_tck_fname'],
+                    DATA['no_magic_number_tck_fname'],
                     lazy_load=lazy_load
                 )
 
     def test_load_no_header_end_file(self):
         for lazy_load in [False, True]:
             with pytest.raises(HeaderError):
                 TckFile.load(
-                    DATA['no-header-end_tck_fname'],
+                    DATA['no_header_end_tck_fname'],
+                    lazy_load=lazy_load
+                )
+
+    def test_load_no_header_end_eof_file(self):
+        for lazy_load in [False, True]:
+            with pytest.raises(HeaderError):
+                TckFile.load(
+                    DATA['no_header_end_eof_tck_fname'],
                     lazy_load=lazy_load
                 )
 

nibabel/tests/data/no-header-end.tck renamed to nibabel/tests/data/no_header_end.tck

@@ -0,0 +1,4 @@
+mrtrix tracks
+count: 0000000000
+datatype: Float32LE
+file: . 67