Add Rubocop and cleanup (#96)

* [Rubocop][Style] Fix Style/StringLiterals
* [Rubocop][Style] Fix Style/EmptyLinesAroundModuleBody
* [Rubocop][Style] Fix Style/EmptyLinesAroundClassBody
* [Rubocop][Style] Fix Style/TrailingCommaInLiteral
* [Rubocop][Style] Fix Style/IfUnlessModifier
* [Rubocop][Style] Fix Style/RaiseArgs
* [Rubocop][Style] Fix Style/CaseIndentation
* [Rubocop][Style] Fix Style/EmptyLines
* [Rubocop][Style] Fix Style/IndentationWidth
* [Rubocop][Style] Fix Style/NumericPredicate
* [Rubocop][Style] Fix Style/SpaceAfterComma
* [Rubocop][Style] Fix Style/ElseAlignment
* [Rubocop][Style] Fix Style/SpaceAroundEqualsInParameterDefault
* [Rubocop][Style] Fix Style/NumericLiterals
* [Rubocop][Style] Fix Style/RedundantReturn
* [Rubocop][Style] Fix Style/RedundantSelf
* [Rubocop][Style] Fix Style/GuardClause
* [Rubocop][Style] Fix Style/AndOrElse
* [Rubocop][Style] Fix Style/SpaceAroundOperators
* [Rubocop][Style] Fix Style/TrivialAccessors
* [Rubocop][Style] Fix Style/SpaceAroundKeyword
* [Rubocop][Style] Fix Style/SpaceInsideHashLiteralBraces
* [Rubocop][Style] Fix Style/SpaceInsideBlockBraces
* [Rubocop][Style] Fix Style/SpaceInsideParens
* [Rubocop][Style] Fix Style/SpaceBeforeBlockBraces
* [Rubocop][Style] Fix Style/MultilineOperationIndentation
* [Rubocop][Style] Fix Style/RedundantParentheses
* [Rubocop][Style] Fix Style/LineEndConcatenation
* [Rubocop][Style] Fix Style/Not
* [Rubocop][Style] Fix Style/NegatedIf
* [Rubocop][Style] Fix Style/ConditionalAssignment
* [Rubocop][Style] Fix Style/ClassCheck
* [Rubocop][Style] Fix Style/ParenthesesAroundCondition
* [Rubocop][Style] Fix Style/WhileUntilModifier
* [Rubocop][Style] Fix Style/RedundantParentheses
* [Rubocop][Style] Fix Style/ClassAndModuleChildren
* [Rubocop][Style] Fix Style/PercentLiteralDelimiters
* [Rubocop][Style] Fix Style/WhileUntilDo
* [Rubocop][Style] Fix Style/RedundantBegin
* [Rubocop][Style] Fix Style/ZeroLengthPredicate
* [Rubocop][Style] Fix Style/EmptyLinesAroundAccessModifier
* [Rubocop][Style] Fix Style/AccessModifierIndentation
* [Rubocop][Style] Fix Style/EmptyMethod
* [Rubocop][Style] Fix Style/UnlessElse
* [Rubocop][Style] Fix Style/IndentationConsistency
* [Rubocop][Style] Fix Style/NestedParenthesizedCalls
* [Rubocop][Style] Fix Style/NegatedWhile
* [Rubocop][Style] Fix Style/EmptyElse
* [Rubocop][Style] Fix Style/ExtraSpacing
* [Rubocop][Style] Fix Style/IfUnlessModifier
* [Rubocop][Style] Fix Style/IndentHash
* [Rubocop][Lint] Fix Lint/UselessAssignment
* [Rubocop][Lint] Fix Lint/Loop
* [Rubocop][Lint] Fix Lint/UselessAccessModifier
* [Rubocop][Lint] Disable Lint/RescueException
* [Rubocop][Lint] Fix Lint/IneffectiveAccessModifier
* [Rubocop][Lint] Disable Lint/InheritException
* [Rubocop][Performance] Disable Performance/RedundantMerge

Author: avellable

.rubocop.yml

@@ -0,0 +1,27 @@
+Style/Documentation:
+  Enabled: false
+Style/HashSyntax:
+  Enabled: false        # Disabled to support older ruby versions
+Style/MutableConstant:
+  Enabled: false
+Style/FormatString:
+  Enabled: false
+
+Lint/RescueException:
+  Enabled: false
+Lint/InheritException:
+  Enabled: false
+
+# TODO: Enable this and fix offenses
+Metrics:
+  Enabled: false
+
+AllCops:
+  Include:
+    - 'lib/**/*'
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'mqtt.gemspec'
+    - 'examples/**'
+    - 'spec/**/*'

Rakefile

@@ -19,12 +19,23 @@ end
 namespace :doc do
   YARD::Rake::YardocTask.new
 
-  desc "Generate HTML report specs"
+  desc 'Generate HTML report specs'
   RSpec::Core::RakeTask.new("spec") do |spec|
     spec.rspec_opts = ["--format", "html", "-o", "doc/spec.html"]
   end
 end
 
 task :test => :spec
 task :specs => :spec
-task :default => :spec
+
+if Gem.ruby_version > Gem::Version.new('2.0')
+  require 'rubocop/rake_task'
+
+  RuboCop::RakeTask.new do |task|
+    task.options = ["-DS"]
+  end
+
+  task :default => [:spec, :rubocop]
+else
+  task :default => :spec
+end

lib/mqtt.rb

@@ -13,7 +13,6 @@
 end
 
 module MQTT
-
   # Default port number for unencrypted connections
   DEFAULT_PORT = 1883
 
@@ -41,7 +40,6 @@ class NotConnectedException < MQTT::Exception
 
   # MQTT-SN
   module SN
-
     # Default port number for unencrypted connections
     DEFAULT_PORT = 1883
 
@@ -50,6 +48,6 @@ module SN
     class ProtocolException < MQTT::Exception
     end
 
-    autoload :Packet,   'mqtt/sn/packet'
+    autoload :Packet, 'mqtt/sn/packet'
   end
 end