fix: don't return 412 for if-none-match failures (#321)

Signed-off-by: flakey5 <[email protected]>

Author: flakey5

src/providers/r2Provider.ts

@@ -180,13 +180,10 @@ function areConditionalHeadersPresent(
 
   const { conditionalHeaders } = options;
 
-  // Only check for if-none-match and if-unmodified-since because the docs said
+  // Only check for if-unmodified-since because the docs said
   //  so, also what nginx does from my experiments
   //  https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/412
-  return (
-    conditionalHeaders.ifNoneMatch !== undefined ||
-    conditionalHeaders.ifUnmodifiedSince !== undefined
-  );
+  return conditionalHeaders.ifUnmodifiedSince !== undefined;
 }
 
 function determineHttpStatusCode(
@@ -208,7 +205,7 @@ function determineHttpStatusCode(
     return 412;
   }
 
-  // We weren't given a body and preconditions succeeded.
+  // We weren't given a body
   return 304;
 }
 

tests/e2e/file.test.ts

@@ -160,7 +160,7 @@ describe('File Tests', () => {
         'if-none-match': originalETag,
       },
     });
-    assert(res.status === 304 || res.status === 412);
+    assert(res.status === 304);
   });
 
   it('handles range header correctly', async () => {