Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes-client introduces deprecations #140

Closed
lholmquist opened this issue Jun 25, 2019 · 3 comments
Closed

kubernetes-client introduces deprecations #140

lholmquist opened this issue Jun 25, 2019 · 3 comments

Comments

@lholmquist
Copy link
Member

After the latest kubernetes-client update, 279846b, some deprecatiions were introduced. Log of the tests:

kubernetes-client deprecated require('kubernetes-client').config, use require('kubernetes-client/backends/request').config. lib/openshift-rest-client.js:25:17
kubernetes-client deprecated require('kubernetes-client').config, use require('kubernetes-client/backends/request').config. index.js:23:39
    ✔ has the OpenshiftClient Object
    ✔ has the config Object

  openshift client tests

kubernetes-client deprecated Client({ config }), see https://github.com/godaddy/kubernetes-client/blob/master/merging-with-kubernetes.md lib/openshift-rest-client.js:89:18
kubernetes-client deprecated Request() without a .kubeconfig option, see https://github.com/godaddy/kubernetes-client/blob/master/merging-with-kubernetes.md node_modules/kubernetes-client/lib/swagger-client.js:199:19

At some point we are going to need to update to the new way of doing things

@lholmquist
Copy link
Member Author

closing, fixed in #160

@lholmquist
Copy link
Member Author

reopening because of #162

@lholmquist
Copy link
Member Author

closed via 9f7b379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants