Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Auth doesn't work with OpenShift 4 #166

Closed
tremes opened this issue Sep 23, 2019 · 2 comments
Closed

Basic Auth doesn't work with OpenShift 4 #166

tremes opened this issue Sep 23, 2019 · 2 comments

Comments

@tremes
Copy link
Contributor

tremes commented Sep 23, 2019

The problem is the auth url (https://github.com/nodeshift/openshift-rest-client/blob/master/lib/basic-auth-request.js#L13) is different in OS4 and I think it can't be constructed this way.

I would suggest to add a new optional param to the client settings for setting the authUrl. I'd like to try to work on this.
@lholmquist
Copy link
Member

@tremes Go for it!

tremes added a commit to tremes/openshift-rest-client that referenced this issue Sep 24, 2019
@tremes
nodeshift#166 - add optional auth url param to client settings
c3c2957
@lholmquist
Copy link
Member

closing, addressed in #167

@lance lance mentioned this issue May 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tremes @lholmquist